Get WordPress

Make WordPress Core

Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#61099 closed enhancement (fixed)

Add Style Engine support for nested CSS rules

Reported by: isabel_brison's profile isabel_brison Owned by: isabel_brison's profile isabel_brison
Milestone: 6.6 Priority: normal
Severity: normal Version: trunk
Component: Editor Keywords: gutenberg-merge has-patch
Focuses: Cc:

Description

The changes added to Gutenberg in ​https://github.com/WordPress/gutenberg/pull/58867 and ​https://github.com/WordPress/gutenberg/pull/58922 need to be synced to core.

This work is a preliminary to adding the new grid layout features (Trac ticket for those to come).

Change History (4)

This ticket was mentioned in ​PR #6460 on ​WordPress/wordpress-develop by ​@isabel_brison.
2 months ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/61099

Syncs the changes from ​https://github.com/WordPress/gutenberg/pull/58867 and ​https://github.com/WordPress/gutenberg/pull/58922.

In progress: tests to be added!

​@isabel_brison commented on ​PR #6460:
2 months ago #2

Tests added, marking this ready for review!

#3 @isabel_brison
2 months ago

  • Owner set to isabel_brison
  • Resolution set to fixed
  • Status changed from new to closed

In 58089:

Editor: add Style Engine support for nested CSS rules.

Adds support for passing a $rules_group string to wp_style_engine_get_stylesheet_from_css_rules(), so rules can be nested under a media query, layer or other rule.

Props isabel_brison, ramonopoly.
Fixes #61099.

​@isabel_brison commented on ​PR #6460:
2 months ago #4

Committed in r58089.

Note: See TracTickets for help on using tickets.