Missing translation in login_header() first parameter

[juliobox]

Hey there

Actuel code from WP (wp-login.php):

<?php
function login_header( $title = 'Log In', $message = '', $wp_error = null ) {

The $title here will be print as is, in any language. WordPress uses it the right way by always passing a translatable string as first param, but since there is a default value, some plugins can use it without it (and they do it, i've check wpdirectory, more than 1M install, 7 plugins are doing it).

So we cannot remove the default value or we will break the world in half, we have to choose between this:

<?php
function login_header( $title = 'Log In', $message = '', $wp_error = null ) {
    if ( 'Log In' === $title ) {
        $title = __( 'Log In' );
    }

or

<?php
function login_header( $title = null, $message = '', $wp_error = null ) {
    if ( is_null( $title ) ) {
        $title = __( 'Log In' );
    }

We can also use a ternary test to do it, as you want, the point is, what is the default value now?
In both cases and same as now you can still pass "" to print nothing and it's OK.
By using null as default and passing "Log In" as param you will print a non translated string "Log In" (in any language).
By using "Log In" as default and passing "Log In" as param you will print a correctly translated string "Se connecter" (here in french).

Thanks

[swissspidy]

A null check looks reasonable to me.

<?php
if ( null === $title ) {
        $title = __( 'Log In' );
}

https://core.trac.wordpress.org/ticket/60668

[audrasjb]

The proposed PR looks good to me. Thank you @mainetenance and congrats for your first patch.

Moving to milestone 6.6.

[rajinsharwar]

I was wondering if the null check should be defined at the start of the function before "global...", or if will it even make any difference.

[audrasjb]

It wouldn't make any difference :)
Let's ship this one as proposed.

committed in https://core.trac.wordpress.org/changeset/58209

[audrasjb]

Committed in [58209].

[skithund]

$title is now nullable

[audrasjb]

Good point, thanks!

[audrasjb]

In 58220:

Login and Registration: login_header() docblock update after [58209].

This changeset indicates that the $title parameter is now nullable.

Follow-up to [58209].

Props skithund.
Fixes #60668.

[SergeyBiryukov]

In 58224:

Docs: Clarify that the $wp_error parameter of login_header() is nullable.

Follow-up to [7991], [25701], [28792], [43457], [58209], [58220].

See #60668, #60699.