Make WordPress Core

Opened 7 months ago

Closed 5 days ago

Last modified 5 days ago

#60239 closed defect (bug) (fixed)

Twenty Sixteen: Quote block border width is relative on front end but 4px in editor

Reported by: nidhidhandhukiya's profile nidhidhandhukiya Owned by: karmatosed's profile karmatosed
Milestone: 6.7 Priority: normal
Severity: normal Version: 6.4.2
Component: Bundled Theme Keywords: has-patch commit
Focuses: css Cc:

Description (last modified by sabernhardt)

Steps to reproduce the issue :-

  1. Activate Twenty Sixteen theme.
  2. Choose Quote block.
  3. Now add some text.
  4. Change font size.

When you change the font size and looks both the side in editor and front end you can able to see that there is a difference in border in front side.
But, the border remains same in editor side.

I have attached video for better understanding.
Video URL :- https://share.cleanshot.com/XC73JqNtZcQVs7wbbZMY

Attachments (4)

60239.patch (427 bytes) - added by nidhidhandhukiya 7 months ago.
60239.2.patch (567 bytes) - added by sabernhardt 6 months ago.
setting border width in Quote block section, where it would not need !important, and adding RTL
60239.3.patch (427 bytes) - added by pitamdey 6 months ago.
Yes @kamran8176, I think this will work
60239.4.patch (613 bytes) - added by shailu25 5 days ago.
Patch Updated.

Download all attachments as: .zip

Change History (17)

#1 @nidhidhandhukiya
7 months ago

  • Summary changed from PullQuote block having design issue in editor side in Twenty Sixteen theme. to Quote block having design issue in editor side in Twenty Sixteen theme.

@sabernhardt
6 months ago

setting border width in Quote block section, where it would not need !important, and adding RTL

#2 @sabernhardt
6 months ago

  • Description modified (diff)
  • Focuses css added
  • Keywords has-patch added
  • Summary changed from Quote block having design issue in editor side in Twenty Sixteen theme. to Twenty Sixteen: Quote block border width is relative on front end but 4px in editor

#3 @kamran8176
6 months ago

@nidhidhandhukiya Hello, I checked the issue you mentioned above about the border width issue on Twenty Sixteen: Quote block, I fixed the problem with the below CSS without !important

blockquote.wp-block-quote{
	border-left-width: 4px;
}

@pitamdey
6 months ago

Yes @kamran8176, I think this will work

#4 @karmatosed
12 days ago

  • Owner set to karmatosed
  • Status changed from new to assigned

#5 @sabernhardt
12 days ago

  • Keywords changes-requested added
  • Milestone changed from Awaiting Review to 6.7

I want to use :where(.rtl) for a patch like 60239.2.patch (if we adjust the front end instead of the editor)

Last edited 12 days ago by sabernhardt (previous) (diff)

#6 @karmatosed
11 days ago

@sabernhardt if I am understanding you would like to iterate a new patch with the :where adjustment. That is absolutely fine.

Last edited 11 days ago by karmatosed (previous) (diff)

#7 @karmatosed
7 days ago

  • Owner karmatosed deleted

This ticket was mentioned in Slack in #core-themes by karmatosed. View the logs.


5 days ago

#9 @karmatosed
5 days ago

  • Owner set to sabernhardt

@shailu25
5 days ago

Patch Updated.

#10 @shailu25
5 days ago

  • Keywords changes-requested removed

Updated Patch as per suggested in Above Comment.

#11 @karmatosed
5 days ago

  • Owner changed from sabernhardt to karmatosed

Thank you @shailu25 I will now test.

#12 @karmatosed
5 days ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 58777:

Twenty Sixteen: Fixes Quote block border width changes depending on font size.

When the font size is changed the border on the front was changing in width. This fix resolves that to make sure the width does not adjust.

Props nidhidhandhukiya, sabernhardt, kamran8176, pitamdey, shailu25.
Fixes #60239.

#13 @karmatosed
5 days ago

  • Keywords commit added
Note: See TracTickets for help on using tickets.