Make WordPress Core

Opened 9 months ago

Closed 9 months ago

Last modified 9 months ago

#59665 closed defect (bug) (fixed)

Fix CI jobs: update "packages" > "version" number in 6.5 package-lock.json file.

Reported by: hellofromtonya's profile hellofromTonya Owned by: hellofromtonya's profile hellofromTonya
Milestone: 6.5 Priority: normal
Severity: normal Version: 6.4
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

On trunk the Test npm, JS coding standards, and JS Tests CI jobs are failing on the following task:

Ensure version-controlled files are not modified or deleted.

For example, here's the workflow of the JS coding standards task:

##[debug]/usr/bin/bash -e /home/runner/work/_temp/e1a4dc15-be4a-4570-a40f-53f4b3dc8650.sh
diff --git a/package-lock.json b/package-lock.json
index bcd0df4..a925ec5 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -6,7 +6,7 @@
 	"packages": {
 		"": {
 			"name": "WordPress",
-			"version": "6.4.0",
+			"version": "6.5.0",
 			"license": "GPL-2.0-or-later",
 			"dependencies": {
 				"@emotion/is-prop-valid": "0.8.8",

Notice it's flagging the "version" number in the "packages".

[56966] modified the first "version" number in the package-lock.json, but did not modify the "version" within the "packages".

Looking at what's flagged, 6.5.0 is expected, not 6.4.0.

Change History (4)

This ticket was mentioned in PR #5519 on WordPress/wordpress-develop by @hellofromTonya.


9 months ago
#1

  • Keywords has-patch added

Sets the "packages" > "version" to "6.5.0" in the package-lock.json file, as both versions in the file should be the same.

Trac ticket: https://core.trac.wordpress.org/ticket/59665

@hellofromTonya commented on PR #5519:


9 months ago
#2

Thanks @swissspidy ⭐

The 3 previously failing jobs are now passing, confirming this fix was needed. Committing.

#3 @hellofromTonya
9 months ago

  • Owner set to hellofromTonya
  • Resolution set to fixed
  • Status changed from new to closed

In 56968:

Build/Test Tools: Fix WP version in package-lock.json.

After [56966], CI jobs that check the package-lock.json failed on the "Ensure version-controlled files are not modified or deleted" task.

There are 2 version fields that need to be updated for the new WP version. This changeset updates the "packages" > "version" for 6.5.0.

Follow-up to [56966].

Props swissspidy, benharri.
Unprops hellofromTonya.
Fixes #59665.

Note: See TracTickets for help on using tickets.