Make WordPress Core

Opened 10 months ago

Closed 10 months ago

Last modified 9 months ago

#59642 closed enhancement (duplicate)

Bundled themes: bump versions for 6.4

Reported by: kafleg's profile kafleg Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

We need to bump the version of the bundled theme to 6.4 and also maintain the changelog.

Here is the GitHub PR, https://github.com/WordPress/wordpress-develop/pull/5505

Change History (8)

This ticket was mentioned in PR #5505 on WordPress/wordpress-develop by @kafleg.


10 months ago
#1

Update version, tested upto, changelog and CSS version
Core ticket: https://core.trac.wordpress.org/ticket/59642

#2 @sabernhardt
10 months ago

  • Keywords needs-testing removed
  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed
  • Version trunk deleted

We already have the ticket #58832 for updating theme versions.

@kafleg commented on PR #5505:


10 months ago
#3

@sabernhardt I found small versioning issue in 2019 theme.

The current version of theme in org is 2.5 but I found that the version 2.6 is already released according to readme file and mentioned version, https://codex.wordpress.org/Twenty_Nineteen_Theme_Changelog#Version_2.6

Would you please give a look on it?

@sabernhardt commented on PR #5505:


9 months ago
#4

All 13 themes were updated in August. However, half of them are a version behind that at wordpress.org/themes.

Also note that Twenty Twenty _might_ still have a version 2.4 this month and then 2.5 with the other themes in November (Trac 59576). The special effort of a separate update becomes less valuable each day, though.

@kafleg commented on PR #5505:


9 months ago
#5

All 13 themes were updated in August. However, half of them are a version behind that at ���wordpress.org/themes.

Also note that Twenty Twenty _might_ still have a version 2.4 this month and then 2.5 with the other themes in November (Trac 59576). The special effort of a separate update becomes less valuable each day, though.

What can I do in this case? Can i update the theme version based on the trunk version?

@sabernhardt commented on PR #5505:


9 months ago
#6

@desrosj should be involved in this conversation too. My advice would be to continue updating the version according to trunk.

I would like to know whether Twenty Twenty will have a separate version to fix the iframe editor background color (which was backported to 6.3). If we delay the change three more weeks instead, I could close 59576 as a duplicate of 58832 and change the milestone on 59086 to 6.4. My patch for Twenty Twenty does not (yet) update the "Tested up to" version, but that might be almost as appropriate if released this week as it would be November 7.

@desrosj commented on PR #5505:


9 months ago
#7

Thanks all for working on this!

I've gone back and tried to find a reason why those themes were not uploaded on 6.3 release day and I couldn't find any. I have gone back and uploaded the updates for all of those that were missing in the state that they were on release day. This includes Twenty Twenty without the iframe changes.

I think it's best to just include the iframe change in 2 weeks with the WP 6.4 coordinated release, which will now be 2.4.

I still need to give a true review to this PR, but wanted to update my progress so far. Will circle back in the next 48 hours to do that, though I think there may be a few updates that need to be added for Twenty Twenty now as well.

@sabernhardt commented on PR #5505:


9 months ago
#8

I made a new PR 5601 that includes Twenty Nineteen to Twenty Twenty-Three, plus it corrects the changelog link for Twenty Twenty-Four.

Note: See TracTickets for help on using tickets.