Comment text regarding wp_min_priority_img_pixels filter in wp_get_loading_optimization_attributes function

[tmatsuur]

The wp_min_priority_img_pixels filter portion of the wp_get_loading_optimization_attributes function is described as follows

/** This filter is documented in wp-admin/includes/media.php */
$wp_min_priority_img_pixels = apply_filters( 'wp_min_priority_img_pixels', 50000 );

I looked in wp-admin/includes/media.php and there is no mention of this filter.

Instead, I found a description of this filter in the wp_maybe_add_fetchpriority_high_attr function in wp-includes/media.php.

Is it possible that the wp_maybe_add_fetch_priority_high_attr function has been changed from wp-admin/includes/media.php to wp-includes/media.php?

If so, that would explain why there was "wp-admin/includes/media.php" in the comment text.

I think the following comment text is correct

/** This filter is documented in wp-includes/media.php */

[SergeyBiryukov]

Thanks for the ticket!

Indeed, the wp_min_priority_img_pixels filter is located in wp-includes/media.php since its introduction in [56037] / #58235 so the proposed change would be correct.

Fixing the comment text of wp-includes/media.php

Trac ticket: https://core.trac.wordpress.org/ticket/59067

[rajinsharwar]

Added the fixed comment

Corrected comment text path for ticket #59067

Trac ticket: #59067

[SergeyBiryukov]

In 56386:

Docs: Correct duplicate hook reference for wp_min_priority_img_pixels.

The original filter location is wp_maybe_add_fetchpriority_high_attr() in wp-includes/media.php.

This commit updates the instance in wp_get_loading_optimization_attributes() to point to the correct file.

Follow-up to [56037], [56143], [56347].

Props tmatsuur, rajinsharwar, khokansardar.
Fixes #59067.

Thanks for the PR! Merged in r56386.

Thanks for the PR! Merged in r56386.

[SergeyBiryukov]

Reopening for 6.3.1 consideration.

[audrasjb]

As per today's bug scrub, marking as dev-reviewed.

[audrasjb]

@SergeyBiryukov I wanted to backport this to branch 6.3 but I had a conflict. Do you reproduce the issue on your side?

[SergeyBiryukov]

In 56429:

Docs: Correct duplicate hook reference for wp_min_priority_img_pixels.

The original filter location is wp_maybe_add_fetchpriority_high_attr() in wp-includes/media.php.

This commit updates the instance in wp_get_loading_optimization_attributes() to point to the correct file.

Follow-up to [56037], [56143], [56347].

Props tmatsuur, rajinsharwar, khokansardar.
Reviewed by azaozz, audrasjb.
Merges [56386] to the 6.3 branch.
Fixes #59067.

[SergeyBiryukov]

Replying to audrasjb:

I wanted to backport this to branch 6.3 but I had a conflict. Do you reproduce the issue on your side?

Yeah, it's because of the changes in [56347] for trunk. I have resolved the conflicts and backported in [56429] :)

[audrasjb]

Thanks! ✌️