Make WordPress Core

Opened 16 months ago

Closed 16 months ago

Last modified 16 months ago

#57969 closed enhancement (duplicate)

Close Button Almost Invisible for More Details on Plugins Add New Page

Reported by: shuvoaftab's profile shuvoaftab Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Plugins Keywords: needs-design-feedback has-screenshots
Focuses: ui, accessibility, css, administration Cc:

Description

Steps to Reproduce:

Plugins => Add New Page => Click on any Plugins More Details

This opens a popup window and the close button on the top right corner is almost invisible regardless of the User Admin Color Scheme

The color is always #135e96 which is close to the shadow and unless clicking on inside the window it does not change to White Color and becomes clearly visible.

Opinion:

Make the Close Button Initially White that is not activated until clicking inside the window.

Attachments (5)

invisible-close-button.png (610.4 KB) - added by shuvoaftab 16 months ago.
Close button almost Invisible with default color scheme
close-button-no-change-after-admin-color-scheme-change.png (638.4 KB) - added by shuvoaftab 16 months ago.
Same color for a different admin color scheme
57969.diff (844 bytes) - added by shuvoaftab 16 months ago.
Patch for the ticket, placing the close modal inside and a little change in color from WordPress Color Palette.
patch1.png (935.7 KB) - added by shuvoaftab 16 months ago.
Output of Patch1
Capture d’écran 2023-03-23 à 14.35.52.png (534.7 KB) - added by audrasjb 16 months ago.
Fixed in WP 6.2

Change History (14)

@shuvoaftab
16 months ago

Close button almost Invisible with default color scheme

#1 @audrasjb
16 months ago

  • Component changed from Administration to Plugins
  • Keywords changes-requested removed
  • Version 6.1.1 deleted

@shuvoaftab
16 months ago

Same color for a different admin color scheme

#2 @audrasjb
16 months ago

Hello, welcome to WordPress Trac and thank you for opening this ticket,

I agree this button style is far from ideal. This was previously discussed in #56604 but I'm sure we can improve a bit more this interface item.

Proposals are welcome :)

#3 @shuvoaftab
16 months ago

Hello @audrasjb ,
Thank you for the reference. I prepared a patch in regard to this enhancement which is also my first patch for WordPress Core along with the First Ticket itself.

To me, instead of placing the Close Modal outside, it looked more convenient inside the window and similar to other places in Dashboard. Since this is my first patch, please review the patch format as well.

Thank you :)

@shuvoaftab
16 months ago

Patch for the ticket, placing the close modal inside and a little change in color from WordPress Color Palette.

@shuvoaftab
16 months ago

Output of Patch1

This ticket was mentioned in Slack in #core by shuvoaftab. View the logs.


16 months ago

#5 @audrasjb
16 months ago

  • Milestone changed from Awaiting Review to 6.3

#6 @costdev
16 months ago

@audrasjb, I believe [55107] resolved this in 6.2 and the blue shouldn't be showing anymore on trunk for any of the admin profiles. Can you verify?

#7 @audrasjb
16 months ago

You're right @costdev!
See the screenshot below :)

#8 @audrasjb
16 months ago

  • Milestone 6.3 deleted
  • Resolution set to worksforme
  • Status changed from new to closed

Thanks for the ticket, but this issue was fixed in [55107].

Closing as worksforme.

#9 @SergeyBiryukov
16 months ago

  • Resolution changed from worksforme to duplicate

Duplicate of #56604.

Note: See TracTickets for help on using tickets.