#57830 closed defect (bug) (fixed)
Block Editor: Revert anchor support for dynamic blocks
Reported by: | Mamaduka | Owned by: | hellofromTonya |
---|---|---|---|
Milestone: | 6.2 | Priority: | normal |
Severity: | normal | Version: | 6.2 |
Component: | Editor | Keywords: | gutenberg-merge has-patch has-testing-info commit |
Focuses: | Cc: |
Description
The featured introduced content markup regression in WP 6.2, and it's too complex to resolve in this cycle. So instead, we're going to remove the feature from the release.
Note: We're not reverting changes made to the $attributes_to_merge
list. It is necessary to continue work on the feature in the Gutenberg plugin.
Original commit: https://core.trac.wordpress.org/changeset/55230
Related Gutenberg PR: https://github.com/WordPress/gutenberg/pull/48592
Testing Instructions
Use the instructions provided in the bug report - https://github.com/WordPress/gutenberg/issues/48232#issue-1590604475.
Attachments (2)
Change History (12)
This ticket was mentioned in PR #4148 on WordPress/wordpress-develop by @Mamaduka.
17 months ago
#1
- Keywords has-patch added
#3
@
17 months ago
- Owner set to hellofromTonya
- Status changed from new to reviewing
Self-assigning for revert commit.
@hellofromTonya commented on PR #4148:
17 months ago
#4
Note: We're not reverting changes made to the
$attributes_to_merge
list. It is necessary to continue work on the feature in the Gutenberg plugin.
So this is a partial revert of https://core.trac.wordpress.org/changeset/55230.
@Mamaduka commented on PR #4148:
17 months ago
#5
@hellofromtonya, correct. Only removing ABSPATH . WPINC . '/block-supports/anchor.php'
file, but keeping the $attributes_to_merge
change, so we can continue work in the plugin.
#6
@
17 months ago
- Keywords has-testing-info added
Testing Instructions
Steps to Reproduce
- Step 1: Create a new post.
- Step 2: Switch to the
Code Editor
. - Step 3: Insert the following markup into the editor:
<!-- wp:paragraph --> <p>Paragraph without anchor</p> <!-- /wp:paragraph --> <!-- wp:paragraph --> <p id="anchor">Paragraph with anchor</p> <!-- /wp:paragraph --> <!-- wp:heading --> <h2>Heading without anchor</h2> <!-- /wp:heading --> <!-- wp:heading --> <h2 id="anchor">Heading with anchor</h2> <!-- /wp:heading --> <!-- wp:group {"layout":{"type":"constrained"}} --> <div id="anchor" class="wp-block-group"></div> <!-- /wp:group -->
- Step 4: Publish (or update) the post. 🐞 The markup is changed.
Expected Results:
When testing a patch to validate it works as expected:
- ✅ The markup should not change.
When reproducing the bug:
- The markup is changed to:
<!-- wp:paragraph --> <p>Paragraph without anchor</p> <!-- /wp:paragraph --> <!-- wp:paragraph --> <p><p id="anchor">Paragraph with anchor</p></p> <!-- /wp:paragraph --> <!-- wp:heading --> <h2 class="wp-block-heading">Heading without anchor</h2> <!-- /wp:heading --> <!-- wp:heading {"anchor":"anchor"} --> <h2 class="wp-block-heading" id="anchor">Heading with anchor</h2> <!-- /wp:heading --> <!-- wp:group {"layout":{"type":"constrained"}} /--> }} Issues: * The paragraph block with the anchor are nested in the `p` element * A comment about `anchor` attributes has been added to the heading block * The anchor in the group block are missing **Test Report Icons:** 🐞 <= Indicates where issue ("bug") occurs. ✅ <= Behavior is ''expected''. ❌ <= Behavior is ''NOT expected''.
#7
@
17 months ago
- Version set to trunk
Test Report
Patch tested: https://github.com/WordPress/wordpress-develop/pull/4148
Environment
- OS: macOS
- Localhost: wp-env (Docker)
- Browser: Chrome
- Plugins: none
- Theme: TT3
- WordPress:
trunk
Actual Results
When reproducing a bug/defect:
- ❌ Able to reproduce the issue as shown in trac57830-before-fix-applied.gif
When testing the bugfix patch:
- ✅ The patch resolves the issue as shown in Trac57830-after-applying-fix.gif
@hellofromTonya commented on PR #4148:
17 months ago
#10
Committed via https://core.trac.wordpress.org/changeset/55443.
Trac ticket: https://core.trac.wordpress.org/ticket/57830