Check the function set_time_limit() exist before calling

[mujuonly]

The function set_time_limit() is used in multiple places in /wp-includes/class-pop3.php without check the function exist.

This throws a fatal error on certain environments.

This avoids a fatal error if the function is disabled on certain environments. This can be handled like ( strpos(ini_get('disable_functions'), 'set_time_limit') === false ) as well.

This avoids a fatal error if the function is disabled on certain environments. This can be handled like ( strpos(ini_get('disable_functions'), 'set_time_limit') === false ) as well.

Trac ticket: https://core.trac.wordpress.org/ticket/57659

[SergeyBiryukov]

Hi there, welcome back to WordPress Trac! Thanks for the ticket.

I considered including this change in [55258] / #55711. Technically, class-pop3.php is an "adopted" library with some changes over the years, mostly PHP compatibility adjustments and typo fixes.

Since it's not actively supported and it was not immediately clear to me whether this code is ever executed in core, I chose not to include this file in [55258] at the time, though I don't have any objections to making this change. Curious to see what others think :)

[mujuonly]

The file is included in /wp-mail.php #L32

/** Get the POP3 class with which to access the mailbox. */
require_once ABSPATH . WPINC . '/class-pop3.php';

[SergeyBiryukov]

Yeah, it appears to be used for the "Post via email" functionality.

On second thought, I don't see any downsides to adding a check for set_time_limit() in this file too, so might as well do it for consistency with the rest of core.

Minor nitpick: since the file does not follow WordPress coding standards, it would be more internally consistent here to use double quotes and avoid spaces between brackets. This can be adjusted on commit.

[SergeyBiryukov]

In 55305:

Mail: Check that set_time_limit() function is available before using it in class-pop3.php.

This avoids a fatal error if the function is disabled on certain environments.

Follow-up to [55258].

Props mujuonly.
Fixes #57659.

Thanks for the PR! Merged in r55305.