Make WordPress Core

Opened 2 years ago

Closed 3 months ago

#56441 closed defect (bug) (invalid)

Pull quote block border issue in different themes.

Reported by: nidhidhandhukiya's profile nidhidhandhukiya Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch has-screenshots needs-testing reporter-feedback close
Focuses: Cc:

Description

I have observed pullquote block is having borders missing in so many themes.

Here is the list of themes which is having the issue in border.

  1. Twenty seventeen.
  2. Twenty Fifteen.
  3. Twenty Fourteen.
  4. Twenty Thirteen.

Attachments (5)

twenty-thirteen-theme-pullquote-issue.png (305.1 KB) - added by nidhidhandhukiya 2 years ago.
I have attached screenshot for better understanding.
twenty-fifteen-theme-pullquote-issue.png (134.6 KB) - added by nidhidhandhukiya 2 years ago.
twenty-seventeen-theme-pullquote-issue.png (402.3 KB) - added by nidhidhandhukiya 2 years ago.
56441.patch (2.8 KB) - added by nidhidhandhukiya 2 years ago.
tt4.png (11.9 KB) - added by mayur8991 3 months ago.
Pull quote block border issue in TT4 Theme

Download all attachments as: .zip

Change History (12)

@nidhidhandhukiya
2 years ago

I have attached screenshot for better understanding.

#1 @nidhidhandhukiya
2 years ago

  • Keywords has-patch has-screenshots added

This issue is already listed in the Gutenberg repository.
https://github.com/WordPress/gutenberg/issues/43566

But I thought this is theme specific because many themes have the border:0 css.

#2 @adamwood
2 years ago

This appears to be a duplicate of https://core.trac.wordpress.org/ticket/55974

I have had a PR open for a couple of months now https://github.com/WordPress/wordpress-develop/pull/2944

UPDATE: This is not a duplicate, it is related but fixes different themes.

Last edited 2 years ago by adamwood (previous) (diff)

#3 @karmatosed
4 months ago

  • Keywords needs-testing added

#4 @karmatosed
4 months ago

  • Milestone changed from Awaiting Review to Future Release

#5 @mayur8991
3 months ago

Twenty Twenty-Four 1.1 Theme also have same issue.

@mayur8991
3 months ago

Pull quote block border issue in TT4 Theme

#6 @poena
3 months ago

  • Keywords reporter-feedback close added

@nidhidhandhukiya Hi!

Not using borders may be an intentional part of the design, like it is in Twenty Twenty-Four.
A missing border is not a bug unless it has been removed from the design by mistake.
To determine that, there needs to be a comparison between the original and current designs.

But if the border options are not working (the controls in the editor) then that would be a bug.
Can you clarify if this ticket is for the controls not working, or for the default designs?

#7 @karmatosed
3 months ago

  • Milestone Future Release deleted
  • Resolution set to invalid
  • Status changed from new to closed

I am also unsure how valid this is @poena so think we need some clarification of what is expected.

  1. Some themes have borders, others do not by design. This is part of the theme design and not all have to.
  2. We won't be patching all themes with borders.

Now, if a theme does support borders and the border doesn't work, that's a different use case. @nidhidhandhukiya is that what you are experiencing here and in which themes? My recommendation would be to close this large ticket and work through one by one as this isn't an issue to cover all as was initially thought. Therefore, I stand by the recommendation @poena made to close and will be doing that.

Thank you everyone. The next steps should be to be clear:

  1. Check each theme and see if it was intended to have a border.
  2. If the theme was intended to have a border and doesn't then work on a fix to resolve the bug.
Note: See TracTickets for help on using tickets.