Make WordPress Core

Opened 2 years ago

Closed 21 months ago

#56383 closed task (blessed) (fixed)

Import Twenty Twenty-Three

Reported by: audrasjb's profile audrasjb Owned by: desrosj's profile desrosj
Milestone: 6.1 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch has-unit-tests commit dev-reviewed i18n-change
Focuses: Cc:

Description

The default theme for 2023 should be added to trunk/wp-content/themes in time for the feature freeze on September 20, 2022.

Twenty Twenty-Three is currently being developed on this GitHub repository: https://github.com/WordPress/twentytwentythree/

Previously: #54318.

Change History (35)

#1 @desrosj
23 months ago

  • Keywords needs-patch added
  • Owner set to desrosj
  • Status changed from new to assigned

Self-assigning as I've agreed to run point on merging.

This ticket was mentioned in PR #3280 on WordPress/wordpress-develop by mikachan.


23 months ago
#2

  • Keywords has-patch added; needs-patch removed

This PR is the initial bulk merge for the new default theme, Twenty Twenty-Three (https://github.com/WordPress/twentytwentythree).

Trac ticket: https://core.trac.wordpress.org/ticket/56383

This ticket was mentioned in PR #3281 on WordPress/wordpress-develop by desrosj.


23 months ago
#3

  • Keywords has-unit-tests added

This is blocked until #3280 is merged.

Trac ticket: https://core.trac.wordpress.org/ticket/56383

mikachan commented on PR #3280:


23 months ago
#4

Thanks for the review, @desrosj! I believe I've addressed all the feedback here.

#5 @desrosj
23 months ago

In 54235:

Bundled Themes: Import Twenty Twenty-Three, the new default theme for WordPress 6.1.

Twenty Twenty-Three is a stripped-back, minimal version of Twenty Twenty-Two that includes a collection of 10 distinct style variations designed and submitted by members of the WordPress community.

This unique approach to creating a default theme harnesses all of the flexibility that full site editing has to offer.

Everybody loves you when you’re twenty-three. What’s my age again?

Props amjadr360, anariel-design, audrasjb, beafialho, bgardner, colorful-tones, critterverse, daisyo, desrosj, dianeco, greenshady, joen, jffng, kafleg, kishanjasani, kraftbj, luminuu, madhudollu, mikachan, mtias, onemaggie, pbking , poena, richtabor, scruffian, soean, tanvirul, thelovekesh.
See #56383.

desrosj commented on PR #3280:


23 months ago
#6

Merged in https://core.trac.wordpress.org/changeset/54235.

Follow up commit of #3281 to follow.

#7 @desrosj
23 months ago

In 54236:

Themes: Import Twenty Twenty-Three is now the default theme.

Follow up to [54235].

See #56383.

This ticket was mentioned in PR #3330 on WordPress/wordpress-develop by mikachan.


22 months ago
#9

This PR syncs the latest changes from the Twenty Twenty-Three repo (https://github.com/WordPress/twentytwentythree), ahead of Beta 2.

Trac ticket: https://core.trac.wordpress.org/ticket/56383

#10 @desrosj
22 months ago

In 54312:

Twenty Twenty-Three: Bug fixes and improvements for beta 2.

This brings over the latest bug fixes and improvements ahead of WordPress 6.1 beta 2, which includes an additional style variation, “Aubergine”.

For a full list of changes being included, see the twentytwentythree repository on GitHub: https://github.com/WordPress/twentytwentythree/compare/1b97bb83f19824c10509011c3ef9f82287d4017b...ac96e8d545a69fc6515312d548b036f267ec7104.

Props mikachan, poena, madhudollu, critterverse, beafialho, felipeelia.
See #56383.

This ticket was mentioned in PR #3397 on WordPress/wordpress-develop by mikachan.


22 months ago
#11

This PR syncs the latest changes from the Twenty Twenty-Three repo (https://github.com/WordPress/twentytwentythree), ahead of Beta 3.

Trac ticket: https://core.trac.wordpress.org/ticket/56383

mikachan commented on PR #3330:


22 months ago
#12

Closing this, as @desrosj already kindly merged this for Beta 2.

#13 @desrosj
22 months ago

In 54372:

Twenty Twenty-Three: Bug fixes and improvements for beta 3.

This brings over the latest bug fixes and improvements ahead of WordPress 6.1 beta 3.

For a full list of changes being included, see the twentytwentythree repository on GitHub: https://github.com/WordPress/twentytwentythree/compare/ac96e8d545a69fc6515312d548b036f267ec7104...ca662828b7e3ae12e03f35903a83cf2cfaa4ce4f.

Props mikachan, poena, madhudollu, beafialho, colorful-tones, scruffian, tahmidulkarim, joen, taskotr, zoonini, mayuge, ndiego, collet.
See #56383.

desrosj commented on PR #3397:


22 months ago
#14

Thanks @mikachan! Merged into Core in https://core.trac.wordpress.org/changeset/54372.

This ticket was mentioned in PR #3427 on WordPress/wordpress-develop by mikachan.


22 months ago
#15

This PR syncs the latest changes from the Twenty Twenty-Three repo (https://github.com/WordPress/twentytwentythree), ahead of RC1.

Trac ticket: https://core.trac.wordpress.org/ticket/56383

cc. @desrosj

#16 @desrosj
22 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 54467:

Twenty Twenty-Three: Bug fixes and improvements for RC1.

Most notably in this update, Twenty Twenty-Three becomes the second default theme to have the “Accessibility Ready” tag.

For a full list of changes being included, see the twentytwentythree repository on GitHub: https://github.com/WordPress/twentytwentythree/compare/ca662828b7e3ae12e03f35903a83cf2cfaa4ce4f...4ea5d832ec9b684dcbf9ac5e67ff4e9ee5ae1e16.

Follow up to [54235], [54236], [54312], [54372].

Props mikachan, madhudollu, tahmidulkarim, joen, poena, scruffian, beafialho, colorful-tones, audrasjb, critterverse, luminuu, wildworks, hiyascout, desrosj.
Fixes #56383.

This ticket was mentioned in PR #3482 on WordPress/wordpress-develop by @mikachan.


22 months ago
#18

This PR syncs the latest changes from the Twenty Twenty-Three repo (https://github.com/WordPress/twentytwentythree), ahead of RC2.

Trac ticket: https://core.trac.wordpress.org/ticket/56383

cc. @desrosj

#19 @desrosj
22 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening to review the RC2 sync.

#20 @desrosj
22 months ago

  • Keywords commit dev-feedback added

PR looks good. Flagging for a second committer review.

#21 @peterwilsoncc
22 months ago

  • Keywords dev-reviewed added; dev-feedback removed

PR LGTM based on a read through of the code.

#22 @desrosj
22 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 54629:

Twenty Twenty-Three: Sync the latest fixes for RC2.

For a full list of changes included, see the twentytwentythree repository on GitHub: https://github.com/WordPress/twentytwentythree/compare/4ea5d832ec9b684dcbf9ac5e67ff4e9ee5ae1e16...0f273d787481b391d428de671659533642b3aa3c.

Props mikachan, beafialho, kafleg, richtabor, poena, annezazu.
Fixes #56383.

This ticket was mentioned in PR #3520 on WordPress/wordpress-develop by @mikachan.


21 months ago
#24

This PR syncs the latest changes from the Twenty Twenty-Three repo (https://github.com/WordPress/twentytwentythree), ahead of RC3.

Trac ticket: https://core.trac.wordpress.org/ticket/56383

cc. @desrosj

@mikachan commented on PR #3520:


21 months ago
#25

Thanks for taking a look, @desrosj.

I've reverted the 'Comments' template part name change, as this was only a small change to make it easier to distinguish between template parts and blocks (there is also a block called 'Comments').

However, I believe the theme description change was requested by someone on the Polyglots team. This is the original PR, and here is the Slack conversation where this was first mentioned. The change to the description was requested because the current description is difficult to translate from English. I understand if this still can't be included, but in this case, it seems likely to be welcomed by the Polyglots team.

@desrosj commented on PR #3520:


21 months ago
#26

However, I believe the theme description change was requested by someone on the Polyglots team. This is the original PR, and here is the Slack conversation where this was first mentioned. The change to the description was requested because the current description is difficult to translate from English. I understand if this still can't be included, but in this case, it seems likely to be welcomed by the Polyglots team.

Ah ha! Thanks for that additional context! Let me get some additional input to make sure this is an exception we can make. It seems reasonable.

#27 @desrosj
21 months ago

  • Keywords dev-reviewed removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening to include the latest PR.

#28 @desrosj
21 months ago

In 54686:

Twenty Twenty-Three: Merge the latest changes from GitHub.

For a full list of changes included, see the twentytwentythree repository on GitHub: https://github.com/WordPress/twentytwentythree/compare/0f273d787481b391d428de671659533642b3aa3c...e2005b0272b8480a8fa9155e5802e22659d84674.

Props kafleg, poena, mikachan, tobifjellner, aristath.
See #56383.

#29 @desrosj
21 months ago

  • Keywords dev-feedback added

Marking for a second committer sign off to backport to the 6.1 branch.

#30 @desrosj
21 months ago

  • Keywords i18n-change added

Since this is a string change, marking i18n-change. I will ping #polyglots in Core Slack after backporting.

This ticket was mentioned in Slack in #core by chaion07. View the logs.


21 months ago

This ticket was mentioned in Slack in #core by desrosj. View the logs.


21 months ago

#34 @SergeyBiryukov
21 months ago

  • Keywords dev-reviewed added; dev-feedback removed

[54686] looks good to backport to the 6.1 branch.

#35 @ocean90
21 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 54691:

Twenty Twenty-Three: Merge the latest changes from GitHub.

For a full list of changes included, see the twentytwentythree repository on GitHub: https://github.com/WordPress/twentytwentythree/compare/0f273d787481b391d428de671659533642b3aa3c...e2005b0272b8480a8fa9155e5802e22659d84674.

Props kafleg, poena, mikachan, tobifjellner, aristath.
Merges [54686] to the 6.1 branch.
Fixes #56383.

Note: See TracTickets for help on using tickets.