Backport missing Gutenberg tests to Core

[antonvlasenko]

WP_Navigation_Test and WP_Global_Styles_Test test classes haven't been backported from Gutenberg to Core.

[antonvlasenko]

I'm working on a patch for this issue.

This PR aims to backport WP_Navigation_Test and WP_Global_Styles_Test test classes to Core.
These tests haven't been back ported to Core.

Trac ticket: https://core.trac.wordpress.org/ticket/56266

[antonvlasenko]

Testing instructions for ​https://github.com/WordPress/wordpress-develop/pull/3005:
Make sure that the unit tests pass.
That PR only contains unit tests.
Props to @ntsekouras for discovering this issue.

Original tests classes:

1. ​https://github.com/WordPress/gutenberg/blob/release/13.6/phpunit/global-styles-test.php
2. ​https://github.com/WordPress/gutenberg/blob/release/13.6/phpunit/navigation-test.php

[costdev]

Thanks @antonvlasenko! I approved the PR and marking for commit consideration. @SergeyBiryukov Do you have time to take a look at this one?

Each of these migrated tests have the same test method name, test_it_correctly_handles_different_post_types(), which seems awkward compared with others in the project. Maybe it's just me, but an alternative might be to simplify it to test_handle_different_post_types(). Why?

• The inclusion of _it_ seems unnecessary in the context of these isolated tests, *UNLESS* additional clarity is desired, in which case this should include the function name under test, which seems pretty common.
• We should assume that unit tests already test for "correct" results, making that word redundant. So "incorrect"/error messages for ​assertions should be defined in their message parameters.
• Like with ​git commit messages, the ​imperative voice tends to read more easily.

Likewise, ​`test_wp_filter_global_styles_post_returns_correct_value()` mentions "correct" in its name, but the test is to "return the same value", hence _return_same_value sounds closer to the intent.

Of course none of this is critical, and maybe only matters to those who stare at unit tests and terminal output! Just </two-cents> 😂

@ironprogrammer Each of these migrated tests have the same test method name, test_it_correctly_handles_different_post_types(), which seems awkward compared with others in the project. Maybe it's just me, but an alternative might be to simplify it to test_handle_different_post_types().

I think test_should_ / test_should_not_ have precedent as test method prefixes in Core and are certainly consistent with wider unit/integration/e2e testing, making it easier for experienced testers when they begin contributing to Core.

I had a longer message in mind, but as this comment will appear on the Trac ticket, I've instead put this in ​a Gist to keep the noise down. I'm curious to hear your thoughts on this, so feel free to DM me on Slack to discuss further.

There is no need to prefix the data provider with data_test_.

My bad. Thanks for the review, @costdev!
I've fixed it.

PR looks good to me! 👍

[robinwpdeveloper]

Latest changes on the PR looks good to me.

[audrasjb]

Let's convert this to a task instead of an enhancement.

[hellofromTonya]

Self-assigning for review and commit.

Rebased on top of current trunk to ensure the new tests cover any changes without introducing any test leaks to other tests.

[hellofromTonya]

In 54382:

Editor: Add PHPUnit tests for 5.9.0 new functions.

During the 5.9.0 cycle, tests were missed during the porting from Gutenberg to Core for the following functions:

• _disable_block_editor_for_navigation_post_type()
• _disable_content_editor_for_navigation_post_type()
• _enable_content_editor_for_navigation_post_type()
• wp_filter_global_styles_post()

This commit adds new test classes for these functions.

Reference:

• ​Gutenberg v13.6 for WP_Global_Styles_Test
• ​Gutenberg v13.6 for WP_Navigation_Test

Follow-up to [52298], [52145], [52052].

Props antonvlasenko, costdev, ironprogrammer, robinwpdeveloper, hellofromTonya.
Fixes #56266.

Committed via changeset https://core.trac.wordpress.org/changeset/54382. Thank you everyone for your contributions!