#54731 closed task (blessed) (fixed)
Make block themes fully support HTML5 by default.
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.9 | Priority: | normal |
Severity: | normal | Version: | 5.9 |
Component: | Themes | Keywords: | has-patch has-unit-tests commit |
Focuses: | Cc: |
Description
Follow-up to #54597.
This ticket proposes that block themes should fully support HTML5 by default.
Per add_theme_support() - HTML5, this includes:
- comment-list
- comment-form
- search-form
- gallery
- caption
- style
- script
Attachments (2)
Change History (18)
This ticket was mentioned in PR #2109 on WordPress/wordpress-develop by costdev.
3 years ago
#1
- Keywords has-patch has-unit-tests added
#3
@
3 years ago
- Version set to trunk
Bringing the conversation here to this ticket to ensure context is here and those involved get props.
Thank you to @joyously who made the suggestion and pointed out that #54597 was too focused on only block content and not non-block content such as support for [gallery]
and [caption]
shortcodes.
For block themes, do you think that Core should automatically default to HTML5 for all content (i.e. block and non-block content)? Or should the block theme itself set the non-block content theme supports (as non-block themes do)?
I think it would be good to force HTML5 for block themes, but that's just an opinion.
+1 That block themes should use HTML5 by default.
As far as I can tell, it would make sense if all block themes could only use and provide HTML5 markup. Block themes are a good way to drop non-HTML5 support in long term, if possible :)
#4
@
3 years ago
What do I think?
I agree. This is a path forward by making new block themes HTML5 out-of-the-box within Core instead of within block themes.
Blocks include their own markup which is already HTML5.
This ticket adds theme supports so that non-block content (original content retained when upgrading to 5.9 and a block theme) is also HTML5.
Please note, non-block themes are not affected this ticket or change.
#6
@
3 years ago
@noisysocks @Mamaduka What do you both think about making block themes default to HTML5 markup? BTW The change in this ticket impacts non-block content in block themes.
#7
@
3 years ago
- Type changed from enhancement to task (blessed)
Changing this ticket to blessed task as block theme and code for this change were introduced in 5.9.
#9
@
3 years ago
- Keywords commit added
w00t thanks @Mamaduka!
Alrighty, marking PR 2109 for commit.
#10
@
3 years ago
Thanks for working on this, @costdev and @hellofromTonya.
Your summary about the decision in the code comment is :chef's kiss emoji:
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
3 years ago
This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.
3 years ago
#13
@
3 years ago
- Owner set to hellofromTonya
- Status changed from new to reviewing
Self-assigning for commit.
hellofromtonya commented on PR #2109:
3 years ago
#16
Committed via https://core.trac.wordpress.org/changeset/52439.
Trac ticket: https://core.trac.wordpress.org/ticket/54731