Twenty Twenty-One: Block "more" text in link can't be changed

[neokendev]

Hi team,
Hope you are well.
I am on basic theme 5.6.2

Quick TT about the block "more" that we can add in article to have the link read more on the home page.

When I add this block I can change the text of the link but for some reason it doesn't show up on home page. Doesn't matter what I change I have always "Poursuivre la lecture de" as a link on my home page. I am on french version.

I didn't find any fix on your doc.

Regards

[neokendev]

When I try with other version than 5.6.2 it's working well

[neokendev]

Sorry quick correction: wordpress version is 5.6.2
but theme is Twenty Twenty-One

[sabernhardt]

There are a few issues here:

1. Showing excerpts created by the "more" tag requires the "Full text" option for Twenty Twenty-One's Excerpt Settings, not the "Summary" setting. So if you use the more tag/block regularly, you will want to go to Customize > Excerpt Settings to switch to Full text.

2. However, Twenty Twenty-One does not support my special more text, and I haven't figured out why not. The other bundled themes worked fine with it, though.

3. Twenty Twenty-One's translator comment does not explain that the post title is visually hidden. (The comment currently is %s: Name of current post.; Twenty Nineteen's comment is %s: Post title. Only visible to screen readers.) I suggested a French translation without "de" before the post title, which will need to be approved or improved.

[sabernhardt]

checking for user-defined "more" text in the_content_more_link, updating comments and docs

[sabernhardt]

I expect the patch needs some polishing, but it worked with my test.

[audrasjb]

Self assigning for review.

@sabernhardt thanks for the translation proposal, I approved the change on translate.wordpress.org👌

[audrasjb]

@sabernhardt I tested 52683.diff, but using "Summary" option on Excerpt settings, I doesn't show any link at all: I have a customized read more block on one post, and a normal post with a lot of text, and in both case I don't have any "more" link. Is it expected?

By the way, we can still commit the Translator string change since it's pretty confusing for translators. Maybe it's worth opening a new ticket for this change?

[sabernhardt]

@audrasjb Long posts should have a "Continue reading" link when blog and archive pages have the "Summary" Excerpt setting.

With Summary, the_excerpt creates a link only when truncating the post text. If the post content is shorter than the excerpt_length value (default 55 words), it does not create a link to continue reading.

But to get More link text specific to a post, that would only work with the Full text setting.

[sabernhardt]

The comment changes are in a separate ticket, #55564, to fix that now. This patch will need a refresh.

[karmatosed]

@audrasjb are you still reviewing this so we can take it through to completion? It would be great to see how we can move this on.