Make WordPress Core

Opened 4 years ago

Last modified 3 years ago

#52070 new defect (bug)

Erase Personal Data & Export Personal Data Table Nav Free Space Issue

Reported by: urvik1's profile urvik1 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 5.6
Component: Privacy Keywords: needs-design-feedback has-screenshots
Focuses: ui, css, administration Cc:

Description

Hello
Erase Personal Data & Export Personal Data Ui Design Mistake
https://www.screenpresso.com/=87BDf
please remove Free Space of "tablenav - top "
apply CSS Display: none;
I think also need to check into the RTL language also.

Thanks.

Attachments (2)

erase-personal-data-tablenav.png (41.4 KB) - added by sabernhardt 4 years ago.
tablenav with bulk actions and item count when there are addresses to list
Empty List Tables.png (435.6 KB) - added by melchoyce 3 years ago.
Seems like this is treated inconsistently across different admin pages. For example, here's posts, pages, comments, and media. Posts display the category dropdown whether or not you have posts or not, taking up that empty space. Comments always displays the navigation tab bar. Pages, like Personal Data, has an empty space. Media has a filter bar AND the empty space. No matter what approach is taken here, it should be applied to other list tables, IMO, to make them more consistent across sections.

Download all attachments as: .zip

Change History (8)

#1 @sabernhardt
4 years ago

  • Component changed from General to Privacy
  • Keywords needs-design-feedback added; needs-design removed

@urvik1 Thanks for the report!

When there are items, that top section does have a Bulk actions dropdown and item count (plus any pagination links). So hiding that only when there are no items requires more than a CSS change.

The display_tablenav function checks for any items after creating the tablenav container div:
https://core.trac.wordpress.org/browser/branches/5.6/src/wp-admin/includes/class-wp-list-table.php?marks=1318#L1307
If we add a no-items class (or similar), then that container could be hidden.

Another possibility for consideration: only show the "No items" message, without markup for either the top section or the table.

@sabernhardt
4 years ago

tablenav with bulk actions and item count when there are addresses to list

#2 @urvik1
4 years ago

Yes, you Right Need to fix these Bulk actions and item count Nav bar not showing.
Thank you for your Reply

#3 @hellofromTonya
4 years ago

  • Keywords needs-patch removed

Removing needs-patch for now.

Why? It's too early in the ticket's lifecycle. At this stage, the ticket is in review. Once moved to a Future Release or into a milestone and design feedback is given, then it will be ready for a patch.

This ticket was mentioned in Slack in #core-css by kirstyburgoine. View the logs.


3 years ago

#5 @kburgoine
3 years ago

After discussing this ticket in #core-css it was pointed out that this ticket: https://core.trac.wordpress.org/ticket/43890 may affect the outcome of this. However @ryelle also noted that this isn't an issue with only the Privacy table, it happens on all list tables so definitely needs design feedback.

Here's the conversation in Slack: https://wordpress.slack.com/archives/CQ7V4966Q/p1611869148077000

@melchoyce
3 years ago

Seems like this is treated inconsistently across different admin pages. For example, here's posts, pages, comments, and media. Posts display the category dropdown whether or not you have posts or not, taking up that empty space. Comments always displays the navigation tab bar. Pages, like Personal Data, has an empty space. Media has a filter bar AND the empty space. No matter what approach is taken here, it should be applied to other list tables, IMO, to make them more consistent across sections.

#6 @melchoyce
3 years ago

  • Keywords has-screenshots added
Note: See TracTickets for help on using tickets.