Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#49536 closed defect (bug) (invalid)

Twenty Twenty: Add esc_html_e on the modal-search.php

Reported by: fahimmurshed's profile fahimmurshed Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.4
Component: Bundled Theme Keywords: has-patch
Focuses: coding-standards Cc:

Description

twentytwenty/template-parts/modal-search.php

<span class="screen-reader-text"><?php esc_html_e( 'Close search', 'twentytwenty' ); ?></span>

Attachments (1)

49536.diff​ (1.8 KB) - added by fahimmurshed 4 years ago.
Patch

Download all attachments as: .zip

Change History (3)

@fahimmurshed
4 years ago

Patch

#1 @TimothyBlynJacobs
4 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Hi @fahimmurshed,

WordPress Core themes don't have their translations escaped in this way. See #30724 for reference.

#2 @SergeyBiryukov
4 years ago

Thanks for the ticket and the patch!

Core translations (including bundled themes) are considered safe because we have a review process for them, see #42639 and the discussion in #30724. (Also related: #32233.) Not all of Theme Check suggestions apply here.

In WordPress core and bundled themes, strings are generally only escaped in attributes or in <option> tags.

Note: See TracTickets for help on using tickets.