Make WordPress Core

Opened 5 years ago

Closed 9 months ago

Last modified 6 months ago

#49233 closed defect (bug) (worksforme)

Settings admin screens: form fields issue on small screens

Reported by: passoniate's profile passoniate Owned by: audrasjb's profile audrasjb
Milestone: Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-screenshots
Focuses: ui, css Cc:

Description

Settings admin screens: form fields issue on small screens

Attachments (5)

general.png (27.7 KB) - added by passoniate 5 years ago.
writing.png (23.1 KB) - added by passoniate 5 years ago.
radio buttons.png (152.5 KB) - added by afercia 4 years ago.
49233 writign settings comparison.png (79.1 KB) - added by afercia 4 years ago.
49233.png (5.9 KB) - added by joedolson 9 months ago.
As of current trunk

Download all attachments as: .zip

Change History (14)

@passoniate
5 years ago

@passoniate
5 years ago

#1 @passoniate
5 years ago

for second issue

@media screen and (max-width: 782px)
.form-table input[type=text].small-text, input[type=number].small-text, input[type=password].small-text, input[type=search].small-text, input[type=text].small-text {
    width: auto;
    max-width: 4.375em;
    display: inline;
    padding: 3px 6px;
    margin: 3px 3px;
}

#2 @audrasjb
5 years ago

Yes, but please note that your selector will apply on a big number of places in WP Admin. It has to be tested on all WordPress Admin screens to ensure there is no regression at all.

#3 @afercia
4 years ago

@passoniate I wasn't able to reproduce the radio buttons overlapping. See attached screenshot. Can you confirm that the bug still exists with the default theme (Twenty Twenty) activated and all other plugins deactivated?

@afercia
4 years ago

#4 @passoniate
4 years ago

Respectable @afercia yes now this bug is fixed

#5 @afercia
4 years ago

  • Focuses accessibility removed
  • Version 5.3.2 deleted

Thanks @passionate. So the only thing to improve is the vertical spacing between form fields on mobile. I think this is a general issue in WordPress though and not limited to the Writing settings page.

It would be nice to address this issue throughout the admin UI: when input fields are stacked vertically they should have some vertical spacing. This would require more standardization and removal of various "exceptions" that were introduced over time to improve the desktop layout, at the cost of a non-optimal mobile layout

For history, see a comparison of this specific case in the screenshot attached below. On the left: WordPress 5.2. On the right: WordPress 5.3.

#6 @passoniate
4 years ago

#50362 was marked as a duplicate.

#7 @SergeyBiryukov
4 years ago

#50362 was marked as a duplicate.

@joedolson
9 months ago

As of current trunk

#8 @joedolson
9 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

This appears to be resolved.

#9 @swissspidy
6 months ago

  • Milestone Awaiting Review deleted
  • Resolution changed from fixed to worksforme
Note: See TracTickets for help on using tickets.