Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#47075 closed defect (bug) (fixed)

Line-height miscalculation on .nav-tab

Reported by: ianbelanger's profile ianbelanger Owned by: ianbelanger's profile ianbelanger
Milestone: 5.2 Priority: normal
Severity: normal Version: 5.2
Component: Administration Keywords: has-patch commit dev-reviewed
Focuses: ui, administration, coding-standards Cc:

Description

As pointed out by @afercia in #46901, the tabs were 1px taller after making .nav-tab line-height unitless in #46493. This ticket was created to address that specific issue.

Attachments (1)

47075.diff​ (443 bytes) - added by ianbelanger 5 years ago.

Download all attachments as: .zip

Change History (5)

@ianbelanger
5 years ago

#1 @ianbelanger
5 years ago

  • Keywords has-patch commit added
  • Milestone changed from Awaiting Review to Future Release

#2 @desrosj
5 years ago

  • Milestone changed from Future Release to 5.2

#3 @desrosj
5 years ago

  • Keywords dev-reviewed added

This will be included in #46901 and was dev-reviewed by @SergeyBiryukov and myself.

#4 @desrosj
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45276:

Help/About: Fix tab display issues.

This change restores About page tab heights and fixes bugs with the tab bottom border caused by [44905] and [45243].

Reviewed by SergeyBiryukov and desrosj.

Props ixkaito, ianbelanger, afercia, SergeyBiryukov.
See #46901.
Fixes #47075.

Note: See TracTickets for help on using tickets.