CA Bundle is way out of date

[paragoninitiativeenterprises]

The latest bundle is from 2018-12-05, the one shipped with WordPress is from 2015-09-16.

https://core.trac.wordpress.org/browser/trunk/src/wp-includes/certificates/ca-bundle.crt

The past 3 years have shown some significant CA revocations, including Symantec's CA certs. I don't believe an outdated CACert bundle is necessarily a vulnerability worth reporting privately, but updating this may prevent corner case of nation state exploitation.

[Otto42]

Related: #30434

[paragoninitiativeenterprises]

Note: When PHP 7+ is the minimum supported by WordPress, it would be advantageous to consider ​https://github.com/paragonie/certainty to automate this, going forward.

[pento]

Given how updating the the CA bundle has caused back compat issues in the past, I'd like to land this change early in the cycle. Milestoning it for 5.2, so it can get a good amount of soak time.

[johnbillion]

Bumping as per comment above

[skithund]

Just to chip in here.

​Let's Encrypt is transitioning to ISRG root, which isn't trusted by the current WordPress CA bundle.

wp eval 'var_dump(wp_remote_get("https://valid-isrgrootx1.letsencrypt.org/"));'

The WP_Error message is cURL error 60: SSL certificate problem: unable to get local issuer certificate

[skithund]

Attached is a file with just the latest ca-bundle without any WordPress modifications.
I'll do another patch with WordPress modifications (add 1024 bit root certs back) later.

[skithund]

Another patch, which updates to latest ca-bundle and adds the same 1024bit certificates back as in [35919] with the following exceptions removed:

• GTE CyberTrust Global Root - Expired in 2018-08-13
• ValiCert Class 1 VA - Expires in 2019-06-25
• ValiCert Class 2 VA - Expires in 2019-06-25
• Entrust.net Secure Server CA - Expired in 2019-05-25
• NetLock Business (Class B) Root - Expired in 2019-02-20
• NetLock Express (Class C) Root - Expired in 2019-02-20

[kirasong]

This ticket came up during a scrub.
Is this a good time for an update to the bundle @pento?

[skithund]

The ​latest CA bundle has actually been updated recently (2019-08-28). I'll refresh the patches in a couple of hours.

[garrett-eclipse]

Thanks @skithund appreciate the update

[skithund]

Refreshed patches includes changes only in build date, SHA checksum and one certificate removed (Certinomis - Root CA).

[SergeyBiryukov]

Thanks for the refreshed patches!

For some reason 45807-2-wp1024.diff​ didn't apply cleanly for me, 45807-3-wp1024.diff​ is another refresh.

Let's get this in while still early in the cycle to allow for more testing.

[SergeyBiryukov]

In 46094:

HTTP: Update the Root Certificate bundle.

Keep 1024-bit legacy root certificates re-added in [35919], except for those already expired, for compatibility with older OpenSSL versions.

Props skithund, paragoninitiativeenterprises.
Fixes #45807.

[ocean90]

#46879 was marked as a duplicate.

[SergeyBiryukov]

#43779 was marked as a duplicate.