Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#40659 closed enhancement (fixed)

Post category listing table admin: Need to replace blank space with "No description" when description column is blank

Reported by: pratikgandhi's profile pratikgandhi Owned by: afercia's profile afercia
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch
Focuses: accessibility Cc:

Description

When you see the post category list table from admin panel you will find that the description column shows blank space instead of "text message" which helps to indicate that the description is not available.

I have attached the screenshot for more clarification.

http://www.awesomescreenshot.com/image/2455447/e13c74d4c1489ff1f6806c4a0b7aac42

So, I have replaced the blank space with the _x('No description');

Attachments (2)

40659.patch (534 bytes) - added by pratikgandhi 7 years ago.
Updated description text
40659.2.patch (529 bytes) - added by yahil 7 years ago.

Download all attachments as: .zip

Change History (8)

@pratikgandhi
7 years ago

Updated description text

#1 @afercia
7 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.8.1
  • Owner set to afercia
  • Status changed from new to assigned
  • Version 4.7.4 deleted

See also #40628.

#2 @yahil
7 years ago

@afercia I have made changes on existing .path to improve coding standard.

Solve phpcs notice:

  1. Whitespace found at end of line
  2. expected 1 space before/after closing bracket [ _x( 'Unknown' ); ]
  3. line indented incorrectly

@yahil
7 years ago

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


7 years ago

#4 @SergeyBiryukov
7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 40957:

Administration: In taxonomy list tables, display a dash instead of a blank space and add "No description" as a screen reader text when the term description is blank.

Props pratikgandhi, yahil.
Fixes #40659.

#5 @SergeyBiryukov
7 years ago

  • Milestone changed from 4.8.1 to 4.9

#6 @SergeyBiryukov
7 years ago

In 40960:

Administration: In WP_List_Table::comments_bubble(), replace the mdash with its HTML entity for consistency with the similar code in other list tables.

Props afercia.
See #40659, #32152.

Note: See TracTickets for help on using tickets.