Taking over a locked post does not always load the most recent revision

[johnbillion]

Steps to reproduce:

1. Open up a post for editing, and make some changes to it. Do not save the changes.
2. Open up the same post for editing using a different user account (in a different browser[1]) and click the 'Take over' button when you get the post lock modal.
3. Note that the post that loads is not the most recent autosave of the post, but equally importantly you are not shown the message stating this.
4. Reload the editing screen and you'll be presented with the "There is an autosave of this post that is more recent than the version below." message.

Related: #23697

---

[1] The simplest way to do this is to use an Incognito browser window (and ​User Switching) so you can be logged in as two accounts simultaneously.

[azaozz]

Can reproduce when autosave has not run between steps 1 and 2 above. As it runs on one minute interval, there can be some changes that haven't been saved yet when user B takes over post editing unexpectedly from user A. The last changes from user A are autosaved when the "Post taken over" dialog shows, i.e. after user B has already loaded the screen. Any ideas/suggestions on how to improve this are welcome.

[azaozz]

The gist here is "user B takes over post editing unexpectedly from user A" while A is typing. The only way to fix this would be to change "Take over" to "Request to take over" and then wait for a response, etc.

However we decided (at a dev chat) to not deal with the courtesies involved in taking over post editing for now. In nearly all cases the users would communicate with each other before taking over, but we are not preventing them if they decide to (be rude) boot somebody unexpectedly.

[jackreichert]

3. Note that the post that loads is not the most recent autosave of the post, but equally importantly you are not shown the message stating this.

It seems that this is no longer the case. When trying to reproduce this I saw that when you take over it doesn't load the most recent, but it does show the message. I would say that this is enough for this ticket.