Aabb Reporter
	Description • 18 years ago

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2) Gecko/20070219 Firefox/2.0.0.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2) Gecko/20070219 Firefox/2.0.0.2

When trying to install Google Weblogger Comments extension firefox prevents it by displaying a bar on the top of the browser window. When clicking on the Edit Options button on the bar, nothing happens.

Reproducible: Always

Steps to Reproduce:
1. Go to http://tools.google.com/firefox/webcomments/install.html
2. Click Agree and Install button.
3. Click the Edit Options button.

Actual Results:  
Nothing happens.

Expected Results:  
Popped up a configuration window to allow certain sites to install code.

	Jim Jeffery not reading bug-mail 1/2/11
	Comment 1 • 18 years ago

Functionality has been removed.  Use this extension:
https://addons.mozilla.org/firefox/2821/

	Jim Jeffery not reading bug-mail 1/2/11
	Comment 2 • 18 years ago

(In reply to comment #1)
> Functionality has been removed.  Use this extension:
> https://addons.mozilla.org/firefox/2821/
> 

Ack, nm, posted to wrong bug. 
> 

	Robert Strong (they/them - no direct email)
	Comment 3 • 18 years ago

Appears to be a regression from bug 359012.

JSConsole output
Error: webNav.currentURI has no properties
Source File: chrome://browser/content/browser.js
Line: 580

	Neil Deakin Assignee
	Comment 4 • 18 years ago

Works fine for me. I click the button and get the Install dialog. If I remove
addons.mozilla.org from the whitelist, I get the notification and can click the
button to edit the options.

	Robert Strong (they/them - no direct email)
	Comment 5 • 18 years ago

For myself using the official 2.0.0.2 I get the error as stated in comment #3 with and without removing addons.mozilla.org from the whitelist using a new profile as well as with my regular profile.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2) Gecko/20070219 Firefox/2.0.0.2

	Robert Strong (they/them - no direct email)
	Comment 6 • 18 years ago

Neil, what OS did you test this on? Perhaps this is Windows only.

	Phil Ringnalda (:philor)
	Comment 7 • 18 years ago

Trunk Mac, I get the browsermessage with the broken button; 2.0.0.2 Win, I get the install prompt with amo whitelisted, or a working browsermessage that whitelists amo (mmm, confusing, since their instructions say to whitelist tools.google.com).

Or, possibly it's a race condition, and that should be "dialup, I get the browsermessage with the broken button, decent connection things work (other than GOOG's insistence on confusing hell out of the minority to save the majority a single click)." I can check various other builds and operating systems when I get back to a slow connection later to see if that makes a difference.

	Robert Strong (they/them - no direct email)
	Comment 8 • 18 years ago

Edit Options works after backing out the patch in bug 359012 though it auto-fills with tools.google.com.

	Mike Connor [:mconnor]
	Comment 9 • 18 years ago

This seems to work for most users, until we have a clear view on what's causing the failure here in some cases not going to block.

Should fix this for 1.8.1.4 though.

	Phil Ringnalda (:philor)
	Comment 10 • 18 years ago

Finally remembered to take my laptop to a better connection: yes, race condition (unless Google's insane enough to sniff connection speed and do different things, which I doubt but didn't check).

Over dialup, I get the install-blocked infobar with a broken edit button, and if I manually whitelist tools.google.com I get the install prompt; with the same build (and the same run-instance, for that matter) over a decent connection, I get the install prompt unless I remove addons.mozilla.org from the whitelist, in which case I get an infobar with a working edit button that adds amo.

	Daniel Veditz [:dveditz]
	Comment 11 • 18 years ago

We would like a fix for this, but we're not going to hold the release if we don't get it.

	Neil Deakin Assignee
	Comment 12 • 17 years ago

Can't fix much here unless we have steps to reproduce.

	Phil Ringnalda (:philor)
	Comment 13 • 17 years ago

Sorry if you don't like them, but comment 10 *is* STR - just add

0. Pinch your internet tubes down to 40Kbps or less.

to the STR from comment 0. Connected over dialup, I consistently 100% see the bug; hibernate, go to a faster connection, resume, I don't. I haven't seen Mr. Strong or the reporter say "oh, yeah, I was testing over a crappy-slow connection," but then I also haven't seen anyone else say "no, I went to my mom's with 28.8 AOL dialup, and I still don't see it there."

	Robert Strong (they/them - no direct email)
	Comment 14 • 17 years ago

Neil, are you able to test by either simulating a slow connection or using a slow connection? This is 100% reproduceable for me when using a slow connection.

	Neil Deakin Assignee
	Comment 15 • 17 years ago

(In reply to comment #14)
> Neil, are you able to test by either simulating a slow connection or using a
> slow connection? This is 100% reproduceable for me when using a slow
> connection.
> 

I'm not really able to test that right now, no. Would be nice to get a reduced test here

	Mike Connor [:mconnor]
	Comment 16 • 17 years ago

We need reliable STR here somehow.  Moving to M9, does QA have any utilities for throttling network speed?

	Dave Townsend [:mossop]
	Comment 17 • 17 years ago

Note also that the edit options button is going away in bug 252830

	Phil Ringnalda (:philor)
	Comment 18 • 17 years ago

I'm inclined to vote for WFM, or at least non-blocker. Google has made two significant changes since http://web.archive.org/web/20070202162244js_/tools.google.com/firefox/install.js - they now |setTimeout('addonsDown()', 3000)| instead of the previous 1000, and addonsDown() now directly sets the iframe .src to the XPI URL, instead of the previous (and uncached, so who knows what it was doing) http://tools.google.com/firefox/install2.html?theURLoftheXPI, and one or the other or both mean I can no longer reproduce the bug.

If you still want to fix it as an abstract problem, I think to reproduce you need a page equivalent to https://addons.mozilla.org/google/google_webcomments.html served with nocache headers so you don't wind up with it stuck in your cache, and another page that loads it in an iframe with an adjustable setTimeout() that changes the iframe .src, so you can find the number of milliseconds for your connection speed that will let the addons-equivalent page load and trigger the install, but then will change the iframe's src before the install code finishes checking. And then if reproducing also involves whatever install2.html used to do, I guess you'd have to ask Google what it was doing.

	Mike Connor [:mconnor]
	Comment 19 • 17 years ago

moving out bugs that don't need to block b1

	Dave Townsend [:mossop]
	Comment 20 • 17 years ago

The edit options button now no longer exists, we appear to have no immediate way to test this so I can't say whether this is still a problem with the allow once button.

	Mike Connor [:mconnor]
	Comment 21 • 17 years ago

Clearing blocking flag.  If anyone can still reproduce this in some form, please renominate.

	Mike Connor [:mconnor]
	Comment 22 • 17 years ago

Still may occur on branch, clearing TM.

	zoz
	Comment 23 • 16 years ago

( please excuse my english, i'm french )

I have the 2.0.0.14 version of Firefox on Windows xp

and i have the word: « modifier » on my menu, but it is not efficient !

I use to édit some pages before printing them ( when i print a page ) with my older version.  I was deleting the items that i din't wont to appear on the print page.

But i can't do it anymore !

( But be aware thant i'm not very familiar with complicates download/reinstal actions on my pc. )

big tanks for your help ! if you can !

	Dave Townsend [:mossop]
	Comment 24 • 16 years ago

(In reply to comment #23)
> ( please excuse my english, i'm french )
> 
> I have the 2.0.0.14 version of Firefox on Windows xp
> 
> and i have the word: « modifier » on my menu, but it is not efficient !
> 
> I use to édit some pages before printing them ( when i print a page ) with my
> older version.  I was deleting the items that i din't wont to appear on the
> print page.
> 
> But i can't do it anymore !

Your problems sound completely unrelated to this bug report. Please seek support before going to bugzilla: http://www.mozilla.org/support

	Neil Deakin Assignee
	Comment 25 • 16 years ago

Don't think this is relevant any more.