aleksr_si Assignee
	Description • 18 years ago

The Najdi.si website has changed its encoding from ISO-8859-2 to UTF-8; could we change the search plug-in to reflect in the next series of updates to Firefox 2? Or do we have to wait until the next 'big' version?

It would be really great if we could do this now as it seems the Najdi.si owners are willing to advertise Firefox for free for us, but it would probably be more difficult to get them to give the final 'yes' if their search plug-in wasn't working properly.

Also the owners would like to add a referrer tag to the plug-in so that they can track how many people are using this search plug-in. Can we do that?

	aleksr_si Assignee
	Comment 1 • 18 years ago

This would be the patch. I hope the 'mode="results"' parameter is right - that's what they gave me from Najdi.si, but their search plug-in is a Sherlock one and I'm not sure if this is the right way to go about in this format as well.

	Axel Hecht [:Pike]
	Comment 2 • 18 years ago

CC'ing Mic, she should make the call about the parameter. I'd like to see the actual intended result in the query string, as there is no such thing as a mode in MozSearch. Details on that are on http://developer.mozilla.org/en/docs/Creating_MozSearch_plugins.

Changing the encoding seems like a good thing to do, could you request approval1.8.1.2 instead of approval-l10n? The latter isn't really used anymore.

	aleksr_si Assignee
	Comment 3 • 18 years ago

Comment on attachment 252800 [details] [diff] [review]
Patch

Thanks Axel.

I'm not sure what the mode parameter is meant to do. I tried using the Sherlock plug-in which I was given, and it doesn't seem to come up in the URL at all as a GET attribute. So I imagine it's either some directive for Firefox/Mozilla, or else it may be that the author messed something up.

Shall I send Najdi.si an email and ask what they mean by the parameter?

(I suppose the 'approval1.8.1.2' flag should probably wait until this is cleared up ...)

	:Gavin Sharp [email: gavin@gavinsharp.com]
	Comment 4 • 18 years ago

(In reply to comment #3)
> I'm not sure what the mode parameter is meant to do. I tried using the Sherlock
> plug-in which I was given, and it doesn't seem to come up in the URL at all as
> a GET attribute. So I imagine it's either some directive for Firefox/Mozilla,
> or else it may be that the author messed something up.

As far as I can tell, the 1.5-and-lower search service paid no attention to the mode attribute on <input>s other than to ignore those that contain the exact string "mode=browser" (http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpfe/components/search/src/nsInternetSearchService.cpp&rev=1.252#4630).

The new search service certainly doesn't pay any attention to it, so you should just remove it.

	aleksr_si Assignee
	Comment 5 • 18 years ago

OK, excellent. Here's the new patch with the 'mode' parameter removed. :)

	Mic Berman
	Comment 6 • 18 years ago

hey
from what i understand of the comments above, the only change now to the nadji plug in reflects their change in encoding from ISO-8859-2 to UTF-8 and no longer has a parameter added? 
i apologize but i have a limited understanding if this change impacts the user experience, my sense from the research I've done on wikipedia is there is no change, it's a back end code compliance type of move. if that's correct (no impact to user experience and no parameter required) and the team is ok on adding this as a patch then BD/me would give approval for the change
thanks
mic

	Axel Hecht [:Pike]
	Comment 7 • 18 years ago

Hi Mic,
there is still a change in search parameters, in particular

 sourceid=mozilla-search

becomes

 foxsbar=ff

in the query string. The changes discussed before are merely about the technical implementation of that change.

	Axel Hecht [:Pike]
	Comment 8 • 18 years ago

Comment on attachment 252925 [details] [diff] [review]
Patch #2

This is on Mic's desk, as can be seen in the comments.

	Mic Berman
	Comment 9 • 18 years ago

aleks,
can you explain to me the rationale behind the change in search parameters? i just need to understand the purpose and if there is any functional impact to the user (my guess on the latter question is none).
thanks
mic

	aleksr_si Assignee
	Comment 10 • 18 years ago

There shouldn't be any functional impact to the user.

The change in this parameter (sourceid vs foxsbar) was requested by the Najdi.si site owners because they'd like to monitor how many people use the Firefox search plugin (they use the same parameter in their own downloadable plugin for Firefox - which is available for anyone using the en-US version or Seamonkey, for example). 

I don't know why they can't simply use 'sourceid' - but it is true that 'sourceid' seems to be the default value (it's used in Amazondotcom and Creativecommons search plugins in en-US, for example, and it used to be used in the Google plugin as well, which is I think where it comes from). So they've probably developed their own system to follow this, and sourceid is simply obsolete in this plugin.

So to sum it up - it is only the background process that is affected with changing this parameter. There is no change for the user whatsoever.

Changing the encoding to UTF-8 will, on the other hand, improve user experience, because after the change on the server occurred, the letters č, š and ž in the Slovene alphabet are no longer searchable using this search plugin (as they get incorrectly encoded).

	Mic Berman
	Comment 11 • 18 years ago

Aleks, got you. thanks very much for the explanation, you have BD approval to go ahead. 
Team, I will document this change on our internal wiki page and reference this bug as well.
best
mic

	Axel Hecht [:Pike]
	Comment 12 • 18 years ago

Comment on attachment 252925 [details] [diff] [review]
Patch #2

[sl] approval to update search plugin to match new site encoding, and update tracking code as reviewed by mic for Firefox 2.0.0.2.

Please use the fixed1.8.1.2 and verified1.8.1.2 keywords as appropriate.

	aleksr_si Assignee
	Comment 13 • 18 years ago

Thanks everyone. I've now committed the changed file to CVS, so I'm marking the bug fixed.

	Axel Hecht [:Pike]
	Comment 14 • 18 years ago

Aleks, could you ask Najdi to pull a nightly from ftp and to do an end-to-end test to verify that the search key produces the results they expect? Make sure that the boxens cycled and the have the change, of course.

	aleksr_si Assignee
	Comment 15 • 18 years ago

Yes, of course, I'll do that. Thanks.

	aleksr_si Assignee
	Comment 16 • 18 years ago

The changed plugin works as expected now. I've got a reply from Najdi.si as well, and they're very satisfied with the change (they've tested the plugin as well and say it works as intended).

Hence I'm marking the bug as verified. (Do I need to remove 'fixed1.8.0.2' from the keywords list now?)

Again, thanks everyone for your input. :)

	Axel Hecht [:Pike]
	Comment 17 • 18 years ago

Yep, it should be either fixed or verified. Wasn't exactly sure myself, though, either ;-).