(not reading, please use seth@sspitzer.org instead) Assignee
	Description • 20 years ago

allow a hidden pref ("imageblocker.enabled") to hide image blocking context menu UI.

on request of a browser vendor / distributor.

I'll attach a patch for review.

aiming for Mozilla 1.7, as that's the long lived branch that people will be
shipping off of.

	(not reading, please use seth@sspitzer.org instead) Assignee
	Comment 2 • 20 years ago

I didn't define a default for this pref, but I could. 

I'll request a r= from neil and see what he thinks.

	(not reading, please use seth@sspitzer.org instead) Assignee
	Comment 3 • 20 years ago

mike, could you review?

	Mike Connor [:mconnor]
	Comment 4 • 20 years ago

Comment on attachment 149217 [details] [diff] [review]
patch

so we're not touching the Tools->Image Manager UI options or the pref panel?  I
can live with that

I don't think we need to define a default value in this case, but if we were
going to hide the other UI elements I'd want one

	(not reading, please use seth@sspitzer.org instead) Assignee
	Comment 5 • 20 years ago

> so we're not touching the Tools->Image Manager UI options or the pref panel?  I
> can live with that

right, this pref only affects the context menu item.  and for Mozilla 1.7, this
pref would not be set, so there would be no change.  it is for other browser
distrbutors.

> I don't think we need to define a default value in this case, but if we were
> going to hide the other UI elements I'd want one

ok, thanks for the review.

	(not reading, please use seth@sspitzer.org instead) Assignee
	Comment 6 • 20 years ago

for some history, see http://bugzilla.mozilla.org/show_bug.cgi?id=208882

thanks to dveditz for pointing that out.

	(not reading, please use seth@sspitzer.org instead) Assignee
	Comment 7 • 20 years ago

to summarize the relation ship to
http://bugzilla.mozilla.org/show_bug.cgi?id=208882, this pref does less than it
used too.

now, we just use this pref to hide the context menu item.  

but as mike points out, the rest of the feature is there.

	Daniel Veditz [:dveditz]
	Comment 8 • 20 years ago

Comment on attachment 149217 [details] [diff] [review]
patch

sr=dveditz

	(not reading, please use seth@sspitzer.org instead) Assignee
	Comment 9 • 20 years ago

note, this fix will be on the 1.7 branch only.

I won't be adding this patch to the trunk.  

as per http://bugzilla.mozilla.org/show_bug.cgi?id=208882, that pref is dead.

but 1.7 is the successor to 1.4, and this was in 1.4.

	chris hofmann
	Comment 10 • 20 years ago

Comment on attachment 149217 [details] [diff] [review]
patch

a=chofmann for 1.7

	(not reading, please use seth@sspitzer.org instead) Assignee
	Comment 11 • 20 years ago

fix landed on the 1.7 branch only.

	tyl2
	Comment 12 • 20 years ago

If this patch only affects the context menu, shouldn't the pref name say 
dat? As of now it sounds like it could disable the whole blocking 
mechanism.

	(not reading, please use seth@sspitzer.org instead) Assignee
	Comment 13 • 20 years ago

it is misleand, but that's the pref that 1.4 used.  (1.4 did more disabling than
1.7 will do)

It's staying on the 1.7 branch, to encourage people who used 1.4 to move to 1.7.

	(not reading, please use seth@sspitzer.org instead) Assignee
	Comment 14 • 20 years ago

s/misleand/misleading

	Michael Lefevre
	Comment 15 • 20 years ago

seems this was also landed on aviary

	Mike Connor [:mconnor]
	Comment 16 • 20 years ago

if it did, it would have no effect whatsoever.

	Tracy Walker [:tracy]
	Comment 17 • 20 years ago

verified