Christian :Biesinger (don't email me, ping me on IRC) Assignee
	Description • 21 years ago

---- This is the 1.4 branch version of bug 184971 ----

basically, if windows maps (e.g.) audio/x-mpegurl to .m3u and .m3u has a
mimetype of audio/mpegurl, we show the latter mimetype in the dialog, even if
the server sent the first one, and we also store the wrong type in mimeTypes.rdf.

I would like this fixed on the 1.4 branch, but not with the trunk's patch, which
I consider too large and risky; so filing a new bug.

	Boris Zbarsky [:bzbarsky]
	Comment 2 • 21 years ago

Comment on attachment 129868 [details] [diff] [review]
1.4 branch patch

r=me, but test very very well.

	Darin Fisher
	Comment 3 • 21 years ago

Comment on attachment 129868 [details] [diff] [review]
1.4 branch patch

sr=darin

	Christian :Biesinger (don't email me, ping me on IRC) Assignee
	Comment 4 • 21 years ago

Comment on attachment 129868 [details] [diff] [review]
1.4 branch patch

this fixes a bug where a wrong mimetype gets displayed in a dialog, and where
it looks to the user like data is not stored. Affects windows only.

The risk should be low.

	Christian :Biesinger (don't email me, ping me on IRC) Assignee
	Comment 5 • 21 years ago

oh, and this patch only affects the code when loading files with content that
mozilla can't display.

I tested this by loading files with different mime types, both from hard disk
and over http.

	Asa Dotzler [:asa]
	Comment 6 • 21 years ago

Comment on attachment 129868 [details] [diff] [review]
1.4 branch patch

This is not going to make 1.4.1.  Please re-request aproval after 1.4.1 ships
if you'd like to get this in for 1.4.2.

	Mike Kaply [:mkaply]
	Comment 7 • 21 years ago

Comment on attachment 129868 [details] [diff] [review]
1.4 branch patch

a=mkaply for 1.4.2

	Christian :Biesinger (don't email me, ping me on IRC) Assignee
	Comment 8 • 21 years ago

fixed om 1.4 branch.
Checking in win/nsOSHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/win/nsOSHelperAppService.cpp,v  <-- 
nsOSHelperAppService.cpp
new revision: 1.38.20.1; previous revision: 1.38
done