Open Bug 1861236 Opened 9 months ago Updated 3 months ago

Verify error propagation using QM_TRY macros

Categories

(Core :: Storage: Quota Manager, task, P3)

Product:
Core
Component:
Storage: Quota Manager
Type:
task

Tracking

()

People

(Reporter: janv, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1861236 - Add a gtest for error propagation verification; r=#dom-storage
48 bytes, text/x-phabricator-request
Details | Review

We added support for exact error stacks in bug 1709352, but the error propagation has never been verified. There's at least one case when QM_TRY doesn't propagate errors using Result::propagateErr (https://searchfox.org/mozilla-central/rev/aa189da432fac500242d9374f044947357f7144e/mfbt/Result.h#630) and it is the support for custom return values. This leads to creating a new error stack every time a custom return value is passed to QM_TRY. I suspect there are other similar cases.

Assignee: nobody → jvarga
Status: NEW → ASSIGNED
Severity: -- → S3
Priority: -- → P3
Assignee: jvarga → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.