Open
Bug 1859947
Opened 9 months ago
Updated 8 months ago
Fluent linter doesn't catch quotes if used around placeables
Categories
(Core :: Internationalization: Localization, defect)
Core
Internationalization: Localization
Tracking
()
NEW
People
(Reporter: flod, Unassigned)
Details
firefoxview-search-history-results-header = Search results for '{ $query }'
This should be caught by the linter, but it's not because the check is on visit_TextElement().
Reporter | ||
Comment 1•9 months ago
|
||
I thought I had a reasonable solution, but then I realized how ugly it is:
- By moving the checks to
visit_Message()
, the node's value is the message including comments. The only way I found to remove the comments is to glue together parts and reserialize the message. - The message includes function calls and parameterized terms. To remove these, I'm using regular expressions.
- The line reference always points to the first line of the message, even if the error is a couple of lines below (e.g. in an attribute).
Assignee: francesco.lodolo → nobody
Comment 2•8 months ago
|
||
The severity field is not set for this bug.
:eemeli, could you have a look please?
For more information, please visit BugBot documentation.
Flags: needinfo?(earo)
Updated•8 months ago
|
Severity: -- → S3
Flags: needinfo?(earo)
You need to log in
before you can comment on or make changes to this bug.
Description
•