Open
Bug 1349007
Opened 7 years ago
Updated 2 years ago
Some GMP overrides of protected methods are public
Categories
(Core :: Audio/Video: GMP, enhancement, P5)
Core
Audio/Video: GMP
Tracking
()
NEW
People
(Reporter: cpearce, Unassigned)
Details
Gerald pointed out that some of our GMP Recv$IPDLMessage function overrides are declared as public, but they're actually inherited from protected methods. i.e. the overrides of protected methods should protected in the derived class too (but nothing in C++ enforces this it seems). https://dxr.mozilla.org/mozilla-central/rev/05bfa2831c0ba4a26fa72328ffe6a99aba9c356a/dom/media/gmp/GMPContentChild.h#26
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•