Avatar uploaded successfully template notice persists

[henrywright]

1. Upload an avatar via members/username/profile/change-avatar/

2. If upload is successful a template notice "Your new avatar was uploaded successfully" will be displayed on the page

3. Now navigate to the settings page (members/username/settings/) by clicking on the Settings link

You will see the "Your new avatar was uploaded successfully" message continues to display on the Settings page. If you now navigate away from the settings page the message disappears.

[henrywright]

Actually why does the member need to stay on the change avatar page after a successful avatar upload? Would it be better to redirect them to their profile which will display their new avatar - that in itself would serve as confirmation the upload was successful. I have opted to use this:

function bp_redirect_after_avatar_upload() {
	bp_core_redirect( bp_loggedin_user_domain() );
}
add_action( 'xprofile_avatar_uploaded', 'bp_redirect_after_avatar_upload' );

I know this doesn't resolve the issue but I'd be grateful for your thoughts...

[DJPaul]

Replying to henrywright:

Actually why does the member need to stay on the change avatar page after a successful avatar upload? Would it be better to redirect them to their profile which will display their new avatar - that in itself would serve as confirmation the upload was successful. I have opted to use this:

I like this idea. Any dissenting opinion from other contributors here?

henrywright, do you want to/are you able to patch this up?

[henrywright]

Hi DJPaul

Please find a patch attached.

[boonebgorges]

I'm a big fan of the new redirect. However, I'd like to keep the message too. The combination should fix the original issue, since the template_notices hook will always appear on the user profile. See 5150.2.patch.

[henrywright]

boonebgorges just tested - works great and also fixes the original issue!

[boonebgorges]

In 7359:

After successful avatar crop, redirect to user domain

Previously, we'd redirected back to the Change Avatar page. But on a
successful crop, this is unneeded. Instead, we send the user back to
his profile, with a success message.

Fixes #5150

Props henrywright