Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sharing] If the Jetpack app doesn't have added blogs sharing error says to open the WordPress app #19704

Open
twstokes opened this issue Dec 1, 2022 · 2 comments

Comments

@twstokes
Copy link
Contributor

twstokes commented Dec 1, 2022

Expected behavior

Error to say "Please launch the Jetpack app..."

Actual behavior

Error says "Please launch the WordPress app..."

RPReplay_Final1669914567.MP4

Steps to reproduce the behavior

  1. Clean install Jetpack - be sure to not log in.
  2. Go to Safari (or any other app that supports sharable content to the apps).
  3. Open the Share Sheet and choose Jetpack.
  4. Observe the "Sharing error" message.

Notes

This string appears to be the same for both apps. Thanks to @mokagio for identifying the LOC.

Tested on iPhone 12, iOS 15, WPiOS 21.4
@mokagio
Copy link
Contributor

mokagio commented Dec 2, 2022

I guess a quick fix would be to use a similar logic as what's currently done to differentiate between "Share" and "Save to Draft", looking into the bundle identifier to discern whether we're in WordPress or Jetpack.

A better fix, though, would be to extract all this shared logic into a framework or local package with various configuration options and then have the extension targets import it and use its methods to show the extension VCs. We could have something like localizedHostAppName for this particular scenario.

@vanessamaartinstt vanessamaartinstt added this to To Do in Groundskeeping via automation Dec 19, 2022
@joashrajin
Copy link

joashrajin commented Jun 8, 2023

I was able to replicate the issue during WCEU too. I tried to share an Audio File with Jetpack and then saw the error:

Screenshot 2023-06-08 at 15 38 29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment