Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter facebook_for_woocommerce_fb_product_description on get_fb_description #2762

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

brezocordero
Copy link

Changes proposed in this Pull Request:

Closes #2756

Adds filter facebook_for_woocommerce_fb_product_description to allow filtering the return of get_fb_description

  • Do the changed files pass phpcs checks? Please remove phpcs:ignore comments in changed files and fix any issues, or delete if not practical. -> I have fixed the linting errors on the modified function only

Screenshots:

Detailed test instructions:

With a site connected to Facebook:

  1. Add the filter to modify the product description, for example:
add_filter( 'facebook_for_woocommerce_fb_product_description', function( $description ) {
  return $description . ' filtered';
});
  1. sync the products
  2. View your catalog on Facebook and check the description is filtered

Additional details:

Changelog entry

Add - Filter facebook_for_woocommerce_fb_product_description

@github-actions github-actions bot added changelog: add A new feature, function, or functionality was added. type: enhancement The issue is a request for an enhancement. labels Jun 25, 2024
@brezocordero brezocordero requested a review from a team June 25, 2024 22:35
@brezocordero brezocordero self-assigned this Jun 25, 2024
@brezocordero brezocordero changed the title Add/2756 filter on description Jun 25, 2024
@message-dimke message-dimke requested review from message-dimke and removed request for a team June 26, 2024 07:57
Copy link
Contributor

@rawdreeg rawdreeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. The changes look good.

PS: Thanks for adding unit tests for this.

@message-dimke message-dimke removed their request for review July 1, 2024 18:17
Copy link
Contributor

@message-dimke message-dimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And yes, thank you for the Unit tests. This is rare these days 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: add A new feature, function, or functionality was added. type: enhancement The issue is a request for an enhancement.
3 participants