Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper attribution for migrated SkyVerge plugin framework files #2422

Open
message-dimke opened this issue Dec 19, 2022 · 0 comments
Open
Labels
type: enhancement The issue is a request for an enhancement.

Comments

@message-dimke
Copy link
Contributor

message-dimke commented Dec 19, 2022

Update SkyVerge migrated files under includes/Framework by adding SkyVerge attributes to it and adding WooCommerce as a co-author for all the migrated files.

Was

/**
 * WooCommerce Admin Message Handler
 *
 * This source file is subject to the GNU General Public License v3.0
 * that is bundled with this package in the file license.txt.
 * It is also available through the world-wide-web at this URL:
 * http://www.gnu.org/licenses/gpl-3.0.html
 * If you did not receive a copy of the license and are unable to
 * obtain it through the world-wide-web, please send an email
 * to license@skyverge.com so we can send you a copy immediately.
 *
 * DISCLAIMER
 *
 * Do not edit or add to this file if you wish to upgrade the plugin to newer
 * versions in the future. If you wish to customize the plugin for your
 * needs please refer to http://www.skyverge.com/
 *
 * @package     SkyVerge/WordPress/WP-Admin-Message-Handler
 * @author      SkyVerge
 * @copyright   Copyright (c) 2013-2019, SkyVerge, Inc.
 * @license     http://www.gnu.org/licenses/gpl-3.0.html GNU General Public License v3.0
 */

Modify to something like this:

/**
 * WooCommerce Admin Message Handler
 *
 * This source file is subject to the GNU General Public License v3.0
 * that is bundled with this package in the file license.txt.
 * It is also available through the world-wide-web at this URL:
 * http://www.gnu.org/licenses/gpl-3.0.html
 * If you did not receive a copy of the license and are unable to
 * obtain it through the world-wide-web, please send an email
 * to license@skyverge.com so we can send you a copy immediately.
 *
 * @author      WooCommerce / SkyVerge
 * @copyright   Copyright (c) 2013-2019, SkyVerge, Inc.
 * @copyright   Copyright (c) 2021-2022, WooCommerce
 * @license     http://www.gnu.org/licenses/gpl-3.0.html GNU General Public License v3.0
 * Modified by WooCommerce on 01 Dececember 2021
 */

NOTE: Currently all the files have no attributes and phpDoc headers on them. Also starting phpDoc v2 it is valid to have multiple @author attributes.

e.g.

/**
 * ...
 * @author SkyVerge
 * @author WooCommerce
 * ...
 */
@message-dimke message-dimke added the type: enhancement The issue is a request for an enhancement. label Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement The issue is a request for an enhancement.
1 participant