Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate & remove likely unused inline script data section #1967

Open
budzanowski opened this issue May 18, 2021 · 0 comments
Open

Investigate & remove likely unused inline script data section #1967

budzanowski opened this issue May 18, 2021 · 0 comments
Labels
needs investigation priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: task The issue is an internally driven task (e.g. from another A8c team).

Comments

@budzanowski
Copy link
Collaborator

Investigate if we need, and in case we don't remove the following code section:

https://github.com/woocommerce/facebook-for-woocommerce/blob/master/facebook-commerce.php#L835-L870

From briefly looking at the code it looks like this is no longer used.
@budzanowski budzanowski added needs investigation priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: enhancement The issue is a request for an enhancement. labels May 18, 2021
@budzanowski budzanowski mentioned this issue May 18, 2021
Merged
@haszari haszari changed the title Possibly remove not used inline script section. May 18, 2021
@haszari haszari added type: task The issue is an internally driven task (e.g. from another A8c team). and removed type: enhancement The issue is a request for an enhancement. labels May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs investigation priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: task The issue is an internally driven task (e.g. from another A8c team).
2 participants
@haszari @budzanowski