Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: TOC should come after left-hand navigation and before main content in focus order #22849

Closed
patrickhlauke opened this issue Jun 17, 2017 · 4 comments

Comments

@patrickhlauke
Copy link
Member

Currently the TOC comes after the main content of the page in terms of focus order. For a keyboard user, it means that the TOC which is supposed to help quickly navigate to a section in the page can only be reached after going through the entire page.

Focus order should be as roughly illustrated below (left hand navigation, TOC, main content)

focus-order

@mustafa-online
Copy link

@patrickhlauke Dude, How do u browse docs off-line ?!
.

@patrickhlauke
Copy link
Member Author

@mdo mdo added the has-pr label Jun 17, 2017
@mdo
Copy link
Member

mdo commented Jun 17, 2017

Good call! #22851

@mdo mdo added this to the v4.0.0-beta milestone Jun 17, 2017
@mdo mdo added this to Safe to merge in v4 Beta 1 Jun 17, 2017
@mdo mdo moved this from Safe to merge to Shipped in v4 Beta 1 Jun 17, 2017
@patrickhlauke
Copy link
Member Author

@mdo just wanted to pop in (late) to verify that #22851 indeed fixes the problem. only outlier at the moment (at least from my testing on Windows) is Firefox <= 54. But Firefox's behavior has been harmonized with what other browsers (including IE11!) do https://bugzilla.mozilla.org/show_bug.cgi?id=812687 and just confirmed it's working fine in Firefox 55 beta. tl;dr: thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment