Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Was jQuery discarded and later reintroduced as a dependency? #214

Open
antoniobrandao opened this issue Nov 1, 2019 · 2 comments
Open

Was jQuery discarded and later reintroduced as a dependency? #214

antoniobrandao opened this issue Nov 1, 2019 · 2 comments

Comments

@antoniobrandao
Copy link

I noticed jQuery is present in the current 0.2.0 version of nprogress.

Wasn't it removed before? PR: #28

First saw the JS request in the Network tab, weighting 29.3kb gzipped, and looking at the package.json of nprogress I see it is indeed included.

"devDependencies": {
    ...
    "jquery": "^2.1.1",

Would be great if we could do away with it. Or you guys find it really necessary?
@jonatandorozco
Copy link

It was introduced to simplify testing process. You can see it on test/test.js
@danbulant
Copy link

@antoniobrandao devDependencies aren't usually bundled (at least not by default on most bundlers) though. Are you sure other dependency of yours isn't using it?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@antoniobrandao @jonatandorozco @danbulant