fix(pip-compile): Correctly report errors when a lock file is unchanged #29363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pip-compile manager can update multiple lock files when a single input file changes, however the manager would short-circuit and return null as soon as a single lock file remained unchanged after being re-compiled. This was causing two issues: 1. Updates to a later lock file could be missed. This is fairly unlikely since the manager trys not to re-compile lock files for which the input haven't changed. 2. Errors in one lock file update could be swolloed if a later lock file update succeeded but made no changes. This scenario was quite likely, especially in the case where one lock file depends on another since the first failure will result in an unchanged upstream lock file. This removes the short-circuit behavior so that the manager will re-compile all of the lock files that depend on the changed input file no matter what.
rarkins
approved these changes
May 31, 2024
|
🎉 This PR is included in version 37.382.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The pip-compile manager can update multiple lock files when a single input file changes, however the manager would short-circuit and return null as soon as a single lock file remained unchanged after being re-compiled.
This was causing two issues:
This removes the short-circuit behavior so that the manager will re-compile all of the lock files that depend on the changed input file no matter what.
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: