Make base_url optional in #tags_for #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would make more sense to let |
|
@ddfreyne Yes you are right... I mean, it really make sense. Check the appending commit 😄 |
|
This looks good! Could you make sure to update the tests too? |
|
Test function added! |
|
Looks good. Thanks! |
denisdefreyne
added a commit
that referenced
this pull request
Aug 8, 2015
Make base_url optional in #tags_for
|
With pleasure 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using version 4.0.2rc2, one error occurred after
Tagginghelper andtags_formethod were added into my code, which told me a KeyError around keybase_url.I checked the source in release-4.0.x and found that
base_urlmust be provided or there will be an error here. It's never been listed in the document or the official tutorial.In my mind it's not so important that users MUST have a link to a tag, at least there should be a default tag link url.
Thank you so much for your review.