Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed no email in Subscribe input area #750

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Fixed no email in Subscribe input area #750

merged 4 commits into from
Dec 11, 2023

Conversation

shivanshsin0203
Copy link
Contributor

Fixes

Fixes #737 by @SoundaryaKoutharapu

Description

I have made span text area to show a message if no email is entered

Technical details

Tests

Screenshots

image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
@shivanshsin0203 shivanshsin0203 requested review from a team as code owners October 30, 2023 11:04
@shivanshsin0203 shivanshsin0203 requested review from annatuma, possumbilities and Dhruvi16 and removed request for a team October 30, 2023 11:04
@cc-open-source-bot cc-open-source-bot added this to Code Review in Active Sprint Oct 30, 2023
@TimidRobot TimidRobot self-assigned this Dec 11, 2023
TimidRobot
TimidRobot approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thank you!!
@TimidRobot TimidRobot merged commit 28aa186 into creativecommons:main Dec 11, 2023
1 check passed
Active Sprint automation moved this from Code Review to Done Dec 11, 2023
@shivanshsin0203
Copy link
Contributor Author

@TimidRobot Sir, I wish to contribute more to the organization, I am well versed in HTML, CSS, and JavaScript, Can you please guide how I can do so?
@TimidRobot
Copy link
Member

@TimidRobot Sir, I wish to contribute more to the organization, I am well versed in HTML, CSS, and JavaScript, Can you please guide how I can do so?

@shivanshsin0203 Please see Creative Commons Open Source for contribution guidelines and our issue finder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@shivanshsin0203 @TimidRobot