Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email textbox not optimized for mobile view #711

Closed
1 task done
soustab10 opened this issue Apr 21, 2023 · 15 comments · Fixed by #763
Closed
1 task done

Email textbox not optimized for mobile view #711

soustab10 opened this issue Apr 21, 2023 · 15 comments · Fixed by #763
Assignees
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🚧 status: blocked Blocked & therefore, not ready for work

Comments

@soustab10
Copy link

Description

The email text box is not optimized for mobile view.

Reproduction

  1. Go to Creative Commons Opensource in mobile view
  2. Scroll to footer
  3. See error.

Expectation

The width of the email text box should be adjusted for the device width.

Screenshots

image

Additional context

Resolution

  • I would be interested in resolving this bug.
@soustab10 soustab10 added 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents labels Apr 21, 2023
@cc-open-source-bot cc-open-source-bot added this to Ready for Development in Active Sprint Apr 21, 2023
@cc-open-source-bot cc-open-source-bot removed this from Ready for Development in Active Sprint Apr 21, 2023
@cc-open-source-bot cc-open-source-bot added this to Pending Review in Backlog Apr 21, 2023
@TimidRobot TimidRobot added help wanted Open to participation from the community good first issue New-contributor friendly 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work 🕹 aspect: interface Concerns end-users' experience with the software and removed 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 💻 aspect: code Concerns the software code in the repository labels Apr 23, 2023
@TimidRobot TimidRobot moved this from Pending Review to Websites in Backlog Apr 23, 2023
@nitin-pandita
Copy link

I would like to work on it @TimidRobot

@adidevs
Copy link
Contributor

adidevs commented May 2, 2023

Hey @nitin-pandita , since you are working on #712 ,shall I take up this issue?

@nitin-pandita
Copy link

Hey @nitin-pandita , since you are working on #712 ,shall I take up this issue?

sure , go for it

@adidevs
Copy link
Contributor

adidevs commented May 2, 2023

@TimidRobot the fix to this issue is in the creativecommons/vocabulary-styles repository in the following file footer.scss

It needs to be updated and the following code added in the mobile() section:

@include mobile() {
    .subscription {
      .newsletter {
        width: 100%;
      }
   }
}

Should I submit a PR directly in that repository or create an issue there?

@TimidRobot
Copy link
Member

@adidevs Hmmm... I'll let @possumbilities weigh in. I suspect we may want to mark this issue as blocked pending changes to Vocabulary.

@possumbilities
Copy link
Contributor

@adidevs I would concur with @TimidRobot. There's a fix brewing that would address this differently, but is precisely this Issue in the new changes to Vocabulary. I'd say best to make this status: blocked for now.

@possumbilities possumbilities added 🚧 status: blocked Blocked & therefore, not ready for work and removed 🏁 status: ready for work Ready for work labels May 5, 2023
@adidevs
Copy link
Contributor

adidevs commented May 6, 2023

Thank you for your feedback @possumbilities and @TimidRobot !🙌

@nsundriyal62

This comment was marked as outdated.

@Lavanya-4321

This comment was marked as outdated.

@Ritesh92A
Copy link

I want to work on this issue please assign me this issue.

@Shailendrasingh189
Copy link

Can I work on this issue.

@abhishekjain58
Copy link

I want to work on this issue please assign me this issue.

@Ritesh92A
Copy link

Hey I clearly understood what issue is please assign this issue to me, I will sole it really quickly.

@TimidRobot
Copy link
Member

@Ritesh92A @Shailendrasingh189 @abhishekjain58

Please see Contribution Guidelines — Creative Commons Open Source for how we manage issues and PRs (we generally don't assign issues prior to resolution).

@wisekiran
Copy link
Contributor

Hi, I created a PR with a fix for this: #763

I've tested it locally, please review @TimidRobot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🚧 status: blocked Blocked & therefore, not ready for work