-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email textbox not optimized for mobile view #711
Comments
I would like to work on it @TimidRobot |
Hey @nitin-pandita , since you are working on #712 ,shall I take up this issue? |
sure , go for it |
@TimidRobot the fix to this issue is in the It needs to be updated and the following code added in the @include mobile() {
.subscription {
.newsletter {
width: 100%;
}
}
} Should I submit a PR directly in that repository or create an issue there? |
@adidevs Hmmm... I'll let @possumbilities weigh in. I suspect we may want to mark this issue as blocked pending changes to Vocabulary. |
@adidevs I would concur with @TimidRobot. There's a fix brewing that would address this differently, but is precisely this Issue in the new changes to Vocabulary. I'd say best to make this |
Thank you for your feedback @possumbilities and @TimidRobot !🙌 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
I want to work on this issue please assign me this issue. |
Can I work on this issue. |
I want to work on this issue please assign me this issue. |
Hey I clearly understood what issue is please assign this issue to me, I will sole it really quickly. |
@Ritesh92A @Shailendrasingh189 @abhishekjain58 Please see Contribution Guidelines — Creative Commons Open Source for how we manage issues and PRs (we generally don't assign issues prior to resolution). |
Hi, I created a PR with a fix for this: #763 I've tested it locally, please review @TimidRobot |
Description
The email text box is not optimized for mobile view.
Reproduction
Expectation
The width of the email text box should be adjusted for the device width.
Screenshots
Additional context
Resolution
The text was updated successfully, but these errors were encountered: