Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish cleaning up CSS from move to CSS variables for colors #3028

Merged
merged 16 commits into from
Oct 1, 2021

Conversation

sandymcfadden
Copy link
Contributor

Fix

This is a continuation of moving to CSS variables for colors within the app.
This removes the remaining bits of theme classes and CSS code throughout the app.
This then required a bit of cleanup to fix some of the colors.

A couple of notes:

  • The highlight.js CSS used to style markdown previews is the only remaining thing that does a specific check for light and dark mode to then load the appropriate file in. I'm not sure of a better way to do this.

  • After the cleanup, there are a few minor differences in dark mode. Are we OK with these?

The color of the highlighted icon in the navigation bar from white to blue

Before
Screen Shot 2021-09-29 at 7 01 22 AM
After
Screen Shot 2021-09-29 at 7 01 13 AM

The color of the drag icon when editing tags is slightly different

Before
Screen Shot 2021-09-29 at 7 03 58 AM
After
Screen Shot 2021-09-29 at 7 03 41 AM

The color of delete forever and empty trash button when viewing trash

Before
Screen Shot 2021-09-29 at 7 07 35 AM
After
Screen Shot 2021-09-29 at 7 07 21 AM

Test

  • Smoke test the app in both light and dark mode
  • Ensure everything looks consistent

Release

  • Updated the CSS to complete the move to using CSS variables for colors
@SylvesterWilmott
Copy link
Contributor

Thanks @sandymcfadden, the differences look good to me!

Copy link
Member

@codebykat codebykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed code and smoke-tested, this looks good to me 👍

@sandymcfadden sandymcfadden merged commit 5f16716 into develop Oct 1, 2021
@sandymcfadden sandymcfadden deleted the update/css-color-variable-cleanup branch October 1, 2021 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants