-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish cleaning up CSS from move to CSS variables for colors #3028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandymcfadden
requested review from
codebykat,
belcherj and
SylvesterWilmott
September 29, 2021 10:14
Thanks @sandymcfadden, the differences look good to me! |
SylvesterWilmott
approved these changes
Sep 29, 2021
codebykat
approved these changes
Sep 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed code and smoke-tested, this looks good to me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
This is a continuation of moving to CSS variables for colors within the app.
This removes the remaining bits of theme classes and CSS code throughout the app.
This then required a bit of cleanup to fix some of the colors.
A couple of notes:
The highlight.js CSS used to style markdown previews is the only remaining thing that does a specific check for light and dark mode to then load the appropriate file in. I'm not sure of a better way to do this.
After the cleanup, there are a few minor differences in dark mode. Are we OK with these?
The color of the highlighted icon in the navigation bar from white to blue
The color of the drag icon when editing tags is slightly different
The color of delete forever and empty trash button when viewing trash
Test
Release