Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated note action component to use css variables for colors #3001

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Updated note action component to use css variables for colors #3001

merged 2 commits into from
Sep 17, 2021

Conversation

sandymcfadden
Copy link
Contributor

@sandymcfadden sandymcfadden commented Sep 10, 2021 •
edited
Loading

Fix

This is a continuation of moving to CSS variables for colors within the app.
This updates the Note Action component.

Note: The checkboxes used in this component and elsewhere will need to be updated separately still to allow changing colors more easily. Tracked in #3000

Test

  • Smoke test in light and dark mode
  • Click the note action icon in the upper right
  • Ensure the open panel looks the same
  • Toggle publish ensure spinner and copy still appear the same

Release

  • Updated the Note Action components to use CSS variables for colors
@sandymcfadden sandymcfadden added this to the 2.20.0 milestone Sep 10, 2021
@sandymcfadden sandymcfadden self-assigned this Sep 10, 2021
@sandymcfadden sandymcfadden added this to In progress in New CSS Architecture Sep 10, 2021
codebykat
codebykat requested changes Sep 17, 2021
View reviewed changes
Copy link
Member

@codebykat codebykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have left the component with a transparent background.

Screen Shot 2021-09-16 at 8 18 45 PM

Screen Shot 2021-09-16 at 8 19 00 PM
@sandymcfadden
Copy link
Contributor Author

That's kind of embarrassing, thank you so much for catching that @codebykat.
I guess I only tested in test notes that didn't have content over that far.
It is updated now.
codebykat
codebykat approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@codebykat codebykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why the build is failing but it looks right now! Thanks ❤️
@sandymcfadden sandymcfadden force-pushed the update/note-actions-css-color-variables branch from 7533726 to 02529e3 Compare September 17, 2021 13:52
@sandymcfadden sandymcfadden force-pushed the update/note-actions-css-color-variables branch from 02529e3 to d728a4d Compare September 17, 2021 14:03
@sandymcfadden sandymcfadden merged commit dfcb137 into develop Sep 17, 2021
@sandymcfadden sandymcfadden deleted the update/note-actions-css-color-variables branch September 17, 2021 14:29
@sandymcfadden sandymcfadden moved this from In progress to Done in New CSS Architecture Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@sandymcfadden @codebykat