-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login/Register links, move to secondary navigation, remove adminbar #420
Comments
Done. It's there because it's primarily for logged in users, as that's how you manage your pledge - but if you don't know how to login, probably not actively contributing. |
Ah good note. To clarify, if you are logged in it's okay to show the adminbar across all sections. And in fact ideally we show it across all sections if you're logged in, so you don't get an inverse jump in that case of the adminbar disappearing. |
Is showing menu items like "my favorites" for not logged-in visitors desirable? |
I'd think so, yes, it makes clear a benefit you get from logging in. Besides, clicking Favorites if logged in, would take you to a screen prompting you to do that. |
Doing a quick review of navigating across all sections of WordPress.org this morning, and noticing a jump in the top navigation for every page that shows the adminbar. It seems that in every case where the adminbar shows, it exists to surface the login and register links. Here are pages that show the adminbar for this reason.
News:
Themes:
Plugins:
Patterns:
Learn:
Forums:
Make (both landing and all P2s):
Photos:
FFTF:
Also for reference, when you click "Log In" you see this page:
When you click "Register" you see this page:
In all these cases, those login/register links exist in context of those pages either being editable by contributors, or places where people can submit themes patterns, or otherwise. Those are all page-contextual actions, however, which suggest hierarchically those links should exist in context of the page, rather than in context of the site as they do when they are the first thing on the page.
Outside of fixing the hierarchy, addressing the jump is especially important on mobile, where those buttons get extra prominence and height:
Suggestions
Mockup showing a single unified Log in/Register link:
This single link leans into #241, which puts a "Register" link right on the login page that'll take you there:
![login-register-page](https://cdn.statically.io/img/private-user-images.githubusercontent.com/1204802/319922481-de80c1b7-1bb2-4b31-93eb-d0bf84aed8e1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxMDkyODQsIm5iZiI6MTcyMjEwODk4NCwicGF0aCI6Ii8xMjA0ODAyLzMxOTkyMjQ4MS1kZTgwYzFiNy0xYmIyLTRiMzEtOTNlYi1kMGJmODRhZWQ4ZTEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcyNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MjdUMTkzNjI0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9N2UzNzlmOTA4ZjU4ODUzMTRkYWE5MDM5NDgzNzhlYzFhNDIwOTNhMDdkNDYyNTA1NjlkZGM1MzhhNzUzNjI2NCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.vXFYMcUCcsjkKwCfh_P3h0bLICcjkesBDus8ucGtVUM)
The text was updated successfully, but these errors were encountered: