Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language bar: move below top header. #264

Open
jasmussen opened this issue May 5, 2023 · 3 comments
Open

Language bar: move below top header. #264

jasmussen opened this issue May 5, 2023 · 3 comments
Labels
[Component] Content Bugs or issues related to the page content [Section] Homepage [Status] Needs Design Feedback Feedback is needed on an existing or new component [Status] On Hold Work is paused temporarily

Comments

@jasmussen
Copy link
Contributor

Extracting from #253:

The language banner is in an unconventional position, worth trying at the top below top bar.

Here's what it would look like if we moved the language banner below the top header:

with banner

without banner

The main sticking point here is whether the language bar should be below any featured banner, like the 20th anniversary or SOTW or others. It seems simplest to keep it at the top.

@markbain
Copy link

markbain commented May 5, 2023

A couple of thoughts come to mind:

  1. The current placement, while not ideal, places the message next to what I'd say was the main call to action, the "Get WordPress" button in the body of the page. Moving it to the top would associate it with the button in the menu bar, instead, which I'd say is secondary (even though it comes first). Assuming I am right about this, I think the proximity to the second button is the right choice, although the execution could be improved :)
  2. On mobile, this button is hidden behind the hamburger menu. I don't think the language bar at the top makes sense without this button for context. Also, if you consider the current layout on mobile, the message is placed much closer to the button it relates to than on wider screens, and doesn't feel so out of place (although it could still be tweaked).
@ryelle ryelle transferred this issue from WordPress/wporg-documentation-2022 May 5, 2023
@ryelle
Copy link
Contributor

ryelle commented May 5, 2023

I see how the banner makes it sound like it's specifically about "getting WordPress," but it's actually to direct people to the localized WordPress.org sites… maybe we need different text here?

Maybe as simple as changing it to "WordPress.org"?

WordPress.org is also available in 한국어 and Español.

(dev note— changing this text will probably require updating the source of this translation, see meta-6599).

The main sticking point here is whether the language bar should be below any featured banner, like the 20th anniversary or SOTW or others. It seems simplest to keep it at the top.

I'm not sure if you're still looking for feedback on this, so I'm marking this as Needs Design Feedback. If we should go ahead and move it to the top, you can remove the label.

@ryelle ryelle added [Status] Needs Design Feedback Feedback is needed on an existing or new component [Component] Content Bugs or issues related to the page content labels May 5, 2023
@markbain
Copy link

markbain commented May 8, 2023

Thanks @ryelle for the clarification. Changing the text from "WordPress" to "WordPress.org" would really make this much clearer. As for position, I think a conventional place for a language bar is at the very top of the site, probably top right, above the "Get WordPress" button.

@ryelle ryelle added the [Status] On Hold Work is paused temporarily label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Content Bugs or issues related to the page content [Section] Homepage [Status] Needs Design Feedback Feedback is needed on an existing or new component [Status] On Hold Work is paused temporarily
3 participants