Audit Autoloaded Options Site Health should extend Core's check if available #1274
Labels
[Plugin] Performance Lab
Issue relates to work in the Performance Lab Plugin only
[Type] Bug
An existing feature is broken
Milestone
Bug Description
A simplified version of the Audit Autoloaded Options Site Health from this plugin has been merged into WP trunk (see issue). The Site Health Check in this plugin still works when the plugin is installed on a site running WP nightlies, but instead of extending the check, it replaces it entirely, which means that core filters for things like the
site_status_autoloaded_options_size_limit
no longer work, and instead need to use the plugin specificperflab_aao_autoloaded_options_limit_size_in_bytes
version.Steps to reproduce
https://wordpress.org/wordpress-6.6-beta1.zip
or a nightly version.add_filter( 'site_status_autoloaded_options_size_limit', '__return_zero' );
Suggested approach
The Site Health check in this plugin should still support all supported versions of WordPress (currently 6.4+) so we'll need to do a check to see if there is already a
autoloaded_options
check returned fromWP_Site_Health::get_tests()
before adding our own. If it already exists, then our enhancements to the test like the description added viaperflab_aao_get_autoloaded_options_table()
should hook into various filters like thesite_status_autoloaded_options_limit_description
filter.Optionally, we could already shim in support for anyone using the filters in the 6.6 checks so that they wouldn't have to update their code when upgrading from 6.5 to 6.6 with the Performance Lab plugin running.
The text was updated successfully, but these errors were encountered: