Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio thumbnail does not have a descriptive alt text #497

Open
1 task
obulat opened this issue Sep 22, 2022 · 6 comments
Open
1 task

Audio thumbnail does not have a descriptive alt text #497

obulat opened this issue Sep 22, 2022 · 6 comments
Labels
♿️ aspect: a11y Concerns related to the project's accessibility ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects

Comments

@obulat
Copy link
Contributor

obulat commented Sep 22, 2022

Problem

Alt attribute on the audio thumbnail image does not describe the image.

Description

A descriptive alt attribute should be provided when possible.

Additional context

Reported by Joe Dolson (https://make.wordpress.org/openverse/2022/09/07/frontend-release-v3-4-8-and-a-call-for-a11y-testing/#comment-95)

Implementation

  • 🙋 I would be interested in implementing this feature.
@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature ♿️ aspect: a11y Concerns related to the project's accessibility labels Sep 22, 2022
@dhruvkb
Copy link
Member

dhruvkb commented Oct 7, 2022

Does the audio thumbnail have any inherent value for someone using a screen-reader? Rather than the alt text being "Thumbnail for track <insert track name here>" (which will almost always be read in close proximity to the track name), I would much rather that the image was ARIA-hidden entirely.

Tagging @panchovm for UX guidance.

@dhruvkb dhruvkb added 💬 talk: discussion Open for discussions and feedback design: needed Needs a designer's touch before implementation can begin labels Oct 7, 2022
@zackkrida
Copy link
Member

Looks like SoundCloud uses the track name as the alt text 😢

@obulat
Copy link
Contributor Author

obulat commented Oct 10, 2022

Ideally, we would have the descriptive texts for the thumbnails. But since we don't, I agree that aria-hiding the thumbnail element is a better solution.
Would we add aria-hidden="true" to the div that wraps both the fallback and the image here (instead of adding the title):
https://github.com/WordPress/openverse-frontend/blob/940b686b387e3fcc86a32dd6fdab15a60cc1b19b/src/components/VAudioThumbnail/VAudioThumbnail.vue#L3

@dhruvkb
Copy link
Member

dhruvkb commented Oct 10, 2022

@obulat that seems ideal. By doing that, to an SR, it would seem as if there is no thumbnail.

@obulat obulat transferred this issue from WordPress/openverse-frontend Feb 22, 2023
@obulat obulat added the 🧱 stack: frontend Related to the Nuxt frontend label Feb 22, 2023
@zackkrida zackkrida added good first issue New-contributor friendly help wanted Open to participation from the community and removed 💬 talk: discussion Open for discussions and feedback design: needed Needs a designer's touch before implementation can begin labels Feb 22, 2023
@zackkrida
Copy link
Member

The suggested approach here sounds good. Let's hide the artworks from screen readers. Currently we show title='Cover art for "Wild Dog & White Rose" by Régis V. Gronoff' even if displaying our generative covers, which is misleading.

@kvdotkirti
Copy link

@obulat I would like to attempt resolving this issue, could you please assign it to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♿️ aspect: a11y Concerns related to the project's accessibility ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
4 participants