Fix ov corepack and pdm existence issues #4472
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #4468 by @sarayourfriend
Fixes #4469 by @sarayourfriend
Description
Fixes both issues by first checking if the executable exists on the host. That solves the pdm issue and also the issue with needing to silence errors when running
pnpm
. Corepack logs to stderr, so redirecting it to /dev/null silences its output. To fix that (and because now we know pnpm exists), we can stop redirecting stderr frompnpm store path
and let Corepack's message show for the user to interact with.Testing Instructions
Run
corepack cache clean
locally and confirm thepnpm
command is now interactive. You'll need pnpm installed with corepack to test that, of course.To test the PDM changes, uninstall PDM locally, and then
ov just
should no longer log the command not found error forpdm
.Checklist
Update index.md
).main
) or a parent feature branch.just catalog/generate-docs
for catalogPRs) or the media properties generator (
just catalog/generate-docs media-props
for the catalog or
just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin