Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ov hooks should reference the ov script directly, rather than relying on it being in the PATH #4422

Closed
sarayourfriend opened this issue Jun 1, 2024 · 0 comments · Fixed by #4496
Closed

ov hooks should reference the ov script directly, rather than relying on it being in the PATH #4422

sarayourfriend opened this issue Jun 1, 2024 · 0 comments · Fixed by #4496
Assignees
@sarayourfriend
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: mgmt Related to repo management and automations

Comments

@sarayourfriend
Copy link
Contributor

Description

@krysal reported the problem here: #4409 (comment)

This is a big, because adding ov to your PATH should be optional. The hook scripts should reference ov directly, relative to the CWD of the hook script.
@sarayourfriend sarayourfriend added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase 🧱 stack: mgmt Related to repo management and automations labels Jun 1, 2024
@sarayourfriend sarayourfriend mentioned this issue Jun 1, 2024
Merged
7 tasks
@krysal krysal added 🟧 priority: high Stalls work on the project or its dependents and removed 🟨 priority: medium Not blocking but should be addressed soon labels Jun 14, 2024
@sarayourfriend sarayourfriend self-assigned this Jun 17, 2024
@sarayourfriend sarayourfriend mentioned this issue Jun 17, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: mgmt Related to repo management and automations
2 participants
@krysal @sarayourfriend