Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address disabled vuejs-accessibility/no-static-element-interactions rules #2906

Open
sarayourfriend opened this issue Aug 27, 2023 · 0 comments
Labels
♿️ aspect: a11y Concerns related to the project's accessibility 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend

Comments

@sarayourfriend
Copy link
Contributor

Current Situation

[PR LINK TO COME] upgrades the vuejs eslint accessibility plugin. This upgrade comes with a new no-static-element-interaction rule (PR here).

When upgrading the package, I've had to disable some of these for not knowing how to address them properly (i.e., by adding the correct roles).

Some of these may need to remain disabled because they actually do comply with accessibility standards, just not in a way that a static checker can see (due to code abstractions, etc).

Suggested Improvement

Audit the sites where the rule is disabled and decide whether a code change is needed or if it should remain disabled. If a code change is needed, make the code change. If it should remain disabled (because there isn't an accessibility issue), add a comment explaining that.

@sarayourfriend sarayourfriend added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix ♿️ aspect: a11y Concerns related to the project's accessibility 🧱 stack: frontend Related to the Nuxt frontend labels Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♿️ aspect: a11y Concerns related to the project's accessibility 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
1 participant