Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Review Notes panel to workshop post type #223

Closed
iandunn opened this issue Jun 28, 2021 · 4 comments · Fixed by #244
Closed

Add Review Notes panel to workshop post type #223

iandunn opened this issue Jun 28, 2021 · 4 comments · Fixed by #244
Assignees
Labels
[Component] Content Website development issues related to the content on Learn. Priority - High High priority issue. [Type] Enhancement New feature request for the Learn website.
Milestone

Comments

@iandunn
Copy link
Member

iandunn commented Jun 28, 2021

Workshop Reviewers: When reviewing Meetup and WordCamp applications, Community Deputies have a custom meta box to share vetting notes. Sometimes this information is confidential, especially when a proposed application/applicant may not meet the program guidelines. The current workflow for evaluating workshop submissions is very similar to this process, and the Learn site would benefit from a role for workshop reviewers to have access to a confidential meta box for communicating review notes with one another.

https://make.wordpress.org/training/2021/05/27/proposal-adding-custom-user-roles-to-learn-wordpress/

#220 is tracking the user role functionality, which can be done independent of adding notes. It will need to be done first, though.

@iandunn iandunn added [Type] Enhancement New feature request for the Learn website. [Component] Content Website development issues related to the content on Learn. labels Jun 28, 2021
@coreymckrill
Copy link
Contributor

I'm working on a dotorg plugin for adding "internal notes" to posts that should be able to address this issue and the moderation needs of the pattern directory.

@hlashbrooke hlashbrooke added this to the Audit tool milestone Aug 3, 2021
@hlashbrooke hlashbrooke added the Priority - High High priority issue. label Aug 26, 2021
@coreymckrill
Copy link
Contributor

Update: the Internal Notes plugin is now active on the Learn site, and should be enabled for workshops. Since #220 isn't done yet, anyone who is an editor or higher can read the notes. Here's a bit about how it works:

There's a new sidebar in the block editor where the notes are displayed and managed. The sidebar can be accessed by clicking the Note icon in the upper right:

sidebar-button

The number badge next to the Note icon displays how many internal notes there are.

Adding new notes should be fairly self-explanatory. Click the Add Note button and fill out the form:

note-form

Notes are displayed with the newest ones at the top. Notes can also be deleted by clicking the Trash icon that appears when a note is hovered over or focused. There isn't currently a way to edit an existing note.

@hlashbrooke
Copy link
Collaborator

This looks great! I'm very happy with how this works.

This looks complete to me, but let me know if there's more work that needs to be done before we can close the issue.

@coreymckrill
Copy link
Contributor

This will get closed when #244 merges.

coreymckrill added a commit that referenced this issue Oct 7, 2021
Adds two new custom roles, Lesson Plan Editor and Workshop Reviewer, to the Learn site, which necessitates using custom capability types for the Lesson Plan and Workshop post types. Also introduces a custom capability for viewing/managing internal notes on the Workshop post type (enabled by the Internal Notes plugin), because only Admins/Workshop Reviewers should be able to see the notes, not Editors.

Fixes #220
Fixes #223

Co-authored-by: Ian Dunn <ian@iandunn.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Content Website development issues related to the content on Learn. Priority - High High priority issue. [Type] Enhancement New feature request for the Learn website.
3 participants