Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the PHP minimum supported version to 7.2 #60680

Closed
3 tasks done
anton-vlasenko opened this issue Apr 11, 2024 · 8 comments · Fixed by #60714
Closed
3 tasks done

Increase the PHP minimum supported version to 7.2 #60680

anton-vlasenko opened this issue Apr 11, 2024 · 8 comments · Fixed by #60714
Assignees
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Build Tooling Issues or PRs related to build tooling

Comments

@anton-vlasenko
Copy link
Contributor

anton-vlasenko commented Apr 11, 2024

On April 8th, WordPress announced it is dropping PHP 7.0 and 7.1 support, raising the minimum supported version to PHP 7.2 for WordPress 6.6.0.

https://make.wordpress.org/core/2024/04/08/dropping-support-for-php-7-1/

What is your proposed solution?

To keep parity with WordPress Core, this ticket proposes for Gutenberg to:

  • Raise the minimum support PHP version.
  • Drop the PHP 7.0 and 7.1 CI jobs.

Tasks

  1. Drop PHP 7.0 and 7.1 CI jobs running on WordPress trunk.
    PR: PHP unit test workflow: Try removing 7.0 and 7.1 #60686 (comment)
  2. Get consensus on when to raise the minimum required PHP version.
  3. Change the plugin header Requires PHP: to 7.2.
@anton-vlasenko anton-vlasenko added [Type] Build Tooling Issues or PRs related to build tooling [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Apr 11, 2024
@anton-vlasenko
Copy link
Contributor Author

I'm working on this issue.

@johnbillion
Copy link
Member

#52982 was the previous bump

@talldan
Copy link
Contributor

talldan commented Apr 12, 2024

The CI tests were failing, so 7.0 and 7.1 have been dropped via this PR - PHP unit test workflow: Try removing 7.0 and 7.1.

@anton-vlasenko
Copy link
Contributor Author

The CI tests were failing, so 7.0 and 7.1 have been dropped via this PR - #60686 (comment).

Thank you for pointing this out, @talldan.

@anton-vlasenko
Copy link
Contributor Author

anton-vlasenko commented Apr 12, 2024

The question I have is this: is it acceptable to merge #60714 sooner rather than later?

The argument for merging it now is to keep WordPress Core and Gutenberg in sync, but doing so will break compatibility with WordPress 6.5 and 6.4.

These versions of WordPress support PHP version 7.1 and below, and with the merge of this PR, Gutenberg will drop support for those PHP versions.

There was an excellent discussion at #52344 discussing similar issue, and everyone concluded that it's better not to wait and to raise the minimum PHP version as soon as possible.

Do you think it would also be acceptable to drop support for PHP 7.1 and 7.0 in this manner?

@talldan
Copy link
Contributor

talldan commented Apr 15, 2024

Do you think it would also be acceptable to drop support for PHP 7.1 and 7.0 in this manner?

I personally think it's ok to follow the same process as in #52344.

@anton-vlasenko anton-vlasenko self-assigned this Apr 17, 2024
@ironprogrammer
Copy link
Contributor

+1 for updating now, rather than later. Code worked on and merged from the plugin to Core during the 6.6 cycle wouldn't be expected to support 7.0/7.1 considering their imminent drop of support.

I also agree with a comment in #52344 that refers to Gutenberg as the cutting edge for early access, and not intended to support older WP versions (which, when upgraded, will receive whatever had recently synced from the plugin anyways 👍🏻).

@anton-vlasenko
Copy link
Contributor Author

anton-vlasenko commented Apr 23, 2024

Thank you! The bump has just been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Build Tooling Issues or PRs related to build tooling
9 participants